Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5473066ima; Tue, 5 Feb 2019 12:21:32 -0800 (PST) X-Google-Smtp-Source: AHgI3IbLot2UcjW1RlIP3xf+zyZoq8O2MeeeQbsIPzcW8vYXjAPVhxB1c4OpQ3vt+Dvb1gWo7O7j X-Received: by 2002:a63:ae01:: with SMTP id q1mr6137394pgf.402.1549398092225; Tue, 05 Feb 2019 12:21:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549398092; cv=none; d=google.com; s=arc-20160816; b=JaF5Grud8kbmwOLrkk/euJvtdr5qIZp0VJAhkQFL3Pj60bhgW3/iBb0KTq5ikgu7D2 HRLVt3zy3Wb5kex3mwwKEqHlc9qsxeGa8CerujlO6559Yd0kxySTw2+3F/PWgJaQ05KM SaMbzRioNCPi8l2L6iWZDN9iT1exqO0wPnzgAT/NZP3hQS1m5NsdgX1NeLQfYMVDeF0u /JhTGZqbijcXhm73vKjLdpne4WvT1HnH6U4ZjKRURSExD3Kw9wRqSzDZcpvUY8FOk8RO Fuv93Jk9f75oOp/2B6CqWnXKY/42qDuDMigocojBEBb4meR80QoqsRH9wpIS2psrgrSD h3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1XL4p1KzbLT7FOu+bWY1RW80xv8ugvSqeaBarZcR3pw=; b=w0pWUv802nGuZ7YV/eEhjz95lInV3sNWOqMyKYvLKmDABi28Itp3/KadV6zwpRL/GF X7AK5q/HiZ5RRGQTMXSvxIs5+6TQXWiLR6+kEsHGBciddoNAU5BDWFuXzIByszItyU1k CtgEfZFb1//eiR7yQE99J1jQtHj1wJGII2nlPrjZXGIJEZMQRtTK5iqPxoHkGog7nERy M7DT7jrYvP6d/gqxe7WJPWRauB0b2VibG/vFwUIdwhcuvow9XzcCqM8mG+gghBOyoGO3 L2hWtMm5CDCILB+vhkvb2BadU/LWJvcbIz1TpFju3jyk61z83kcCBWmJTSYh4oIkwzQm ZdyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DbHlLPBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k12si3710376pgg.382.2019.02.05.12.21.15; Tue, 05 Feb 2019 12:21:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DbHlLPBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730120AbfBEUET (ORCPT + 99 others); Tue, 5 Feb 2019 15:04:19 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37360 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727060AbfBEUES (ORCPT ); Tue, 5 Feb 2019 15:04:18 -0500 Received: by mail-pf1-f193.google.com with SMTP id y126so1989669pfb.4; Tue, 05 Feb 2019 12:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1XL4p1KzbLT7FOu+bWY1RW80xv8ugvSqeaBarZcR3pw=; b=DbHlLPBuTl16vFX88Li5/4opcO4azPOjNsQ/32gAkuqWZf8wVHV1/1ybvKTXI4r2GF Mc0J37brpNnNNMLc/Aar3peMjkv9oHip6fWrtaEEFiwDSHJSfZd1lw+k+bLozlHr5bvA v0pd2d3iEkA+RTCgiFaO1GOwj7oTlilmIxq/wPf9pzQFeIFJGe9Ae1ObRdgHXMduFR2y NLRl4SSHGP2v3VaoIGxWfMlyGbDrMzvcOF1hcP9mFsHvfKScY7AgleWiqY9DZ3/vVi22 htJoUjeTqYdQP12uE5TSgksT/lTzVhoROPSCd8PgNYVZFX6rD2myJekh5Qj0Sogm2nLl i7wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1XL4p1KzbLT7FOu+bWY1RW80xv8ugvSqeaBarZcR3pw=; b=MNkEvCLFjxFOpi4duKkXOoajpSc7d+Tfpb7QGNblSSy2cEfSqg4pMvSQKqV82luOra Dtt29k7chyQGQ2WMuWh3CA4RKBXsgNCHeoq85+qhz+cEdY19usmX6zHL6T3yaOf9jz7M 4PtnHVaylDjvVzou4j244LrYe1sBPFNzYW/VBgHXKA8An4B5m0H1FEpG/gYOZ3mLvgUF p0cmIukFqBvIIIAC8qv2TzPrbnVjiGJhmL+6gDn+5Lzf1MtX/z61BznNDioYfM5OvaCs rku1GlJIkZ4vOiyzyMH+mxJfTMjf3MbZt1vPSZSx8BCCjHxJsKdQNlxi82Mml7txsOWA ndOg== X-Gm-Message-State: AHQUAuYLo6VvogPWz380gb5B6pdOiz0w0MPMC0ZWY16OCi1qOViKVB5h F3/0jrUlI/jWg3fEMzbQMpHt9EZS X-Received: by 2002:a63:2c0e:: with SMTP id s14mr6256115pgs.132.1549397057577; Tue, 05 Feb 2019 12:04:17 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id l85sm6724046pfg.161.2019.02.05.12.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 12:04:16 -0800 (PST) Subject: Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing To: Joe Perches , David Miller , thierry.reding@gmail.com Cc: hkallweit1@gmail.com, andrew@lunn.ch, nic_swsd@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190204164213.30727-1-thierry.reding@gmail.com> <20190204164213.30727-2-thierry.reding@gmail.com> <20190204.192040.1074738183781998611.davem@davemloft.net> <8553086eaec167846992f1cff12aa388cee81767.camel@perches.com> From: Eric Dumazet Message-ID: Date: Tue, 5 Feb 2019 12:04:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8553086eaec167846992f1cff12aa388cee81767.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2019 10:42 AM, Joe Perches wrote: > > It's declared after a pointer so it is already is 2 byte aligned. > > A lot of drivers wouldn't work otherwise. Maybe these drivers are only used on arches where this does not matter.