Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5475208ima; Tue, 5 Feb 2019 12:23:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IbWcfkWat6Mt0qTX58ISNhahmx+3HEcJ8PGVeDmEh6irC+At3RoMh8RuyQyWGvIX14wBqNm X-Received: by 2002:a17:902:e384:: with SMTP id ch4mr5729704plb.200.1549398226351; Tue, 05 Feb 2019 12:23:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549398226; cv=none; d=google.com; s=arc-20160816; b=iH8bizQWacr5tfpDdBuMuD2pJir3ZiNT6M0BOqKP+9koyVadw0LtjezdE/ZrYC6uHe DLCZceEX6XE04HnvtU5dApLc4WkKm/w1Jz8/ZVtmMshNtGMIT4PwrB/kb0sQF076uH/M p0TCBQ5AHovnftf89aclDRq4Q3qzqfZNyr0D1qbsJM4pjyPYcUbjmY93agxvTqQqNr5E QQyh+i9yFQFBsahKNQbeqDhBE2eTkGAzidfl4rcjp3BLTHjFQmFS1T26Z5a7mtFWv4FV 98G6Bvcf70CzJxFsYl++aBIxx0F4y4bS585EM4Weud17Ba1tfq0CMLTJZidGm7Kmijhh weDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=PFPF+GcCJuLF5aeyqjtD5PuUm8YLVQ8DYvnGhXRlFQ0=; b=NPTeAfx/R/gSvROSaZGmdGwmbAkDaeXFZ1ep/svu1OVcH8VRcUfE4GNQRzvWTcS1oK HVYXDIsv3vj3Jcgos9flj2U5Xm18kyF+f0jk460FlF4FdNxz5JbcrRE8R4POM6YZJ+Z/ lgMSSkrt91Uogjz4dvvMpevrMH5UIrvHYrgca4+qWeZ0q7gRSf1FbcO2rqFFV8eXh5Kd F6ZbHMhSmnnAzOCBfAy1qsVPAqi0F2Y++Ebh1/NM42RiAihtgT/fW+2MzHQ7uvxCYBvI qB4z4BuioMSyIdlDvO+qAs0mWBuXbIuhvLnYv9qhkL4CYrqNcRB+TeHY4Za/woCKD/4s g8+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si4089421pfb.191.2019.02.05.12.23.30; Tue, 05 Feb 2019 12:23:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729780AbfBEUVg (ORCPT + 99 others); Tue, 5 Feb 2019 15:21:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbfBEUVg (ORCPT ); Tue, 5 Feb 2019 15:21:36 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B9398E59E; Tue, 5 Feb 2019 20:21:36 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-204-71.brq.redhat.com [10.40.204.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2683C1167420; Tue, 5 Feb 2019 20:21:33 +0000 (UTC) From: Laurent Vivier To: linux-kernel@vger.kernel.org Cc: Michael Ellerman , linuxppc-dev@lists.ozlabs.org, David Gibson , Christophe Leroy Subject: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() Date: Tue, 5 Feb 2019 21:21:33 +0100 Message-Id: <20190205202133.5048-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 05 Feb 2019 20:21:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org resize_hpt_for_hotplug() reports a warning when it cannot increase the hash page table ("Unable to resize hash page table to target order") but this is not blocking and can make user thinks something has not worked properly. As we move the message to the debug area, report again the ENODEV error. If the operation cannot be done the real error message will be reported by arch_add_memory() if create_section_mapping() fails. Fixes: 7339390d772dd powerpc/pseries: Don't give a warning when HPT resizing isn't available Signed-off-by: Laurent Vivier --- Notes: v2: - use pr_debug instead of printk(KERN_DEBUG - remove check for ENODEV arch/powerpc/mm/hash_utils_64.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 0cc7fbc3bd1c..6a0cc4eb2c83 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -777,10 +777,9 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size) int rc; rc = mmu_hash_ops.resize_hpt(target_hpt_shift); - if (rc && (rc != -ENODEV)) - printk(KERN_WARNING - "Unable to resize hash page table to target order %d: %d\n", - target_hpt_shift, rc); + if (rc) + pr_debug("Unable to resize hash page table to target order %d: %d\n", + target_hpt_shift, rc); } } -- 2.20.1