Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <4aea523a3bc5be0d944f7ed9fadac276b7115002.camel@perches.com>
Subject: Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing
From:   Joe Perches <joe@perches.com>
To:     Eric Dumazet <eric.dumazet@gmail.com>,
        David Miller <davem@davemloft.net>, thierry.reding@gmail.com
Cc:     hkallweit1@gmail.com, andrew@lunn.ch, nic_swsd@realtek.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 05 Feb 2019 12:18:09 -0800
In-Reply-To: <ca6ca816-af03-e1f9-739a-a06cc4837b80@gmail.com>
References: <20190204164213.30727-1-thierry.reding@gmail.com>
         <20190204164213.30727-2-thierry.reding@gmail.com>
         <20190204.192040.1074738183781998611.davem@davemloft.net>
         <8553086eaec167846992f1cff12aa388cee81767.camel@perches.com>
         <ca6ca816-af03-e1f9-739a-a06cc4837b80@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote:
> 
> On 02/05/2019 10:42 AM, Joe Perches wrote:
> > It's declared after a pointer so it is already is 2 byte aligned.
> > 
> > A lot of drivers wouldn't work otherwise.
> 
> Maybe these drivers are only used on arches where this does not matter.

Possible.

I had only grepped through the sources looking for
declarations using:

$ git grep -B1 '\[ETH_ALEN\];' -- '*.c' | grep -A1 '\*'

It's quite a few files in net/ too btw.

I still think adding __align(<even#>) is unnecessary here unless
it follows something like a bool or a u8.