Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Feb 2019 22:59:55 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     James Bottomley <James.Bottomley@HansenPartnership.com>
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org, roberto.sassu@huawei.com,
        zohar@linux.ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in
 tpm_st33zp24_spi and tpm_i2c_infineon
Message-ID: <20190205205955.GC13023@linux.intel.com>
References: <20190204133749.14176-1-jarkko.sakkinen@linux.intel.com>
 <1549395622.2923.14.camel@HansenPartnership.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1549395622.2923.14.camel@HansenPartnership.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 05, 2019 at 02:40:22PM -0500, James Bottomley wrote:
> On Mon, 2019-02-04 at 15:37 +0200, Jarkko Sakkinen wrote:
> > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c
> > b/drivers/char/tpm/tpm_i2c_infineon.c
> > index 9086edc9066b..b9d5a1dda8d2 100644
> > --- a/drivers/char/tpm/tpm_i2c_infineon.c
> > +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> [...]
> > @@ -527,8 +528,8 @@ static int tpm_tis_i2c_send(struct tpm_chip
> > *chip, u8 *buf, size_t len)
> >  	u8 retries = 0;
> >  	u8 sts = TPM_STS_GO;
> >  
> > -	if (len > TPM_BUFSIZE)
> > -		return -E2BIG;	/* command is too long for our
> > tpm, sorry */
> > +	if (len > TPM_I2C_INFINEON_BUFSIZE)
> 
> TPM_I2C_INFINEON_MAX_BUFSIZE, surely, otherwise it won't compile ...
> the kbuild robot just spotted this as well.

Correct, unluckily, I had unstaged diff.

/Jarkko