Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sobon, Przemyslaw" <psobon@amazon.com>
To:     Boris Brezillon <bbrezillon@kernel.org>,
        Liu Jian <liujian56@huawei.com>,
        "ikegami@allied-telesis.co.jp" <ikegami@allied-telesis.co.jp>
CC:     "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "richard@nod.at" <richard@nod.at>,
        "joakim.tjernlund@infinera.com" <joakim.tjernlund@infinera.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Thread-Topic: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Thread-Index: AQHUu5pgPuG2fN5WMEykck2gQhFtIaXNv4mAgAQNLxA=
Date:   Tue, 5 Feb 2019 22:28:44 +0000
Message-ID: <acd16b85676e4d1d89f3acfbeda30107@EX13D07UWA001.ant.amazon.com>
References: <1548977439-318904-1-git-send-email-liujian56@huawei.com>
        <20190203092645.18d1495b@bbrezillon> <20190203093509.269bf1e1@bbrezillon>
In-Reply-To: <20190203093509.269bf1e1@bbrezillon>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> From: Boris Brezillon <bbrezillon@kernel.org>=20
> Sent: Sunday, February 3, 2019 12:35 AM
> > +Przemyslaw
> >=20
> > On Fri, 1 Feb 2019 07:30:39 +0800
> > Liu Jian <liujian56@huawei.com> wrote:
> >=20
> > > In function do_write_buffer(), in the for loop, there is a case
> > > chip_ready() returns 1 while chip_good() returns 0, so it never=20
> > > break the loop.
> > > To fix this, chip_good() is enough and it should timeout if it stay=20
> > > bad for a while.
> >=20
> > Looks like Przemyslaw reported and fixed the same problem.
> >=20
> > >=20
> > > Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to=20
> > > check correct value)
> >=20
> > Can you put the Fixes tag on a single, and the format is
> >=20
> > Fixes: <hash> ("message")
> >=20
> > > Signed-off-by: Yi Huaijie <yihuaijie@huawei.com>
> > > Signed-off-by: Liu Jian <liujian56@huawei.com>
> >=20
> > [1]http://patchwork.ozlabs.org/patch/1025566/
> >=20
> > > ---
> > >  drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c=20
> > > b/drivers/mtd/chips/cfi_cmdset_0002.c
> > > index 72428b6..818e94b 100644
> > > --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> > > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> > > @@ -1876,14 +1876,14 @@ static int __xipram do_write_buffer(struct ma=
p_info *map, struct flchip *chip,
> > >  			continue;
> > >  		}
> > > =20
> > > -		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> > > -			break;
> > > -
> > >  		if (chip_good(map, adr, datum)) {
> > >  			xip_enable(map, chip, adr);
> > >  			goto op_done;
> > >  		}
> > > =20
> > > +		if (time_after(jiffies, timeo))
> > > +			break;
> > > +
> > >  		/* Latency issues. Drop the lock, wait a while and retry */
> > >  		UDELAY(map, chip, adr, 1);
> > >  	}
> >=20
>=20
> BTW, the patch itself looks good to me. Ikegami, can you confirm it does =
the right thing?
>=20
> Thanks,
>=20
> Boris
>=20

One comment to this patch. If value is written incorrectly quickly we will =
be
stuck in the loop even though nothing is going to change. For example a val=
ue was
written incorrectly after 1us, the loop was set to 1ms, function will retur=
n
after 1ms, this solution is not optimized for performance. I considered sam=
e
when working on this change and decided to do it different way.

Regards,
Przemek