Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5645187ima; Tue, 5 Feb 2019 15:48:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IapoXYVJ/6MzeCEpepz7ZbTUjx9m3onYjyyVH1b/DC0IbTAsbLtDFJ8kpxKMXAs0XplWUDA X-Received: by 2002:a65:490e:: with SMTP id p14mr2283686pgs.373.1549410480047; Tue, 05 Feb 2019 15:48:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549410480; cv=none; d=google.com; s=arc-20160816; b=pXLDy/hcQRlj5M5UpuZoW8eTOTDveSe108GPuyZbzp61LLzkS87A1XZBdvArkGln5+ 6684WqyN1aVqbMcC7I3HwcgcMNPk8GWg2qePb9ZJ0er8rmMpeSYDvCLimPUIySnowumg 6Cx7+G3SnpORUsFSERYKPJMASsB6sSYadsNEzQqQVhY+mVSTO720T3hOh29spdDGYAko qb4TLl/vxkTzDmU5dzdfXhJTD3UGLPQ+aWUg+yb+2c7s0Be/qmgU8rW71G4MA3mPc9w5 dm0DEG3qPJCk/3pKNkewYPhObGZI0ixfuqTgp0nBm4Q7Lx3FCfxhOY6a53k+w9Cakf9i j11g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=kX3KDQJF+iWYUPxR/szNu0I47FnrC45vmOa11B0ogKs=; b=m0T7npn2Vdd9OeytNMM257pifSq0ZGvwteb7JgqYwI0DSBm9Ig9028kOEB2ouLW4MB wKs77mkenYHZH8lDyw9sTB+3GSZPy3hs5i1BG7Im6pyj9ME0q9trf5Jh9LIurOpLpuAX feXUtV16oEDZNib1hXLavFB1facmo1yjSdTDbmAZCRGdwqMNrZjwypWpx44niVHrQrCy MqbXtw4EIRqxXfAvPgM9fNbCxeHm18c5zvXBVEwvFVe8W6gMczXx8wgy6v3iqzUW2QTJ VDgGUCkyCFWAiMarytvBwGndLfZaw7/tg1k1ZEIfg1wawwOV60Jc+qYM7FwHPLqxB59i HxVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si4187338pgj.582.2019.02.05.15.47.44; Tue, 05 Feb 2019 15:48:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727660AbfBEXNq (ORCPT + 99 others); Tue, 5 Feb 2019 18:13:46 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48732 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726484AbfBEXNq (ORCPT ); Tue, 5 Feb 2019 18:13:46 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x15N94k9017149 for ; Tue, 5 Feb 2019 18:13:45 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qfgwerkq3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 05 Feb 2019 18:13:44 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Feb 2019 23:13:42 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 5 Feb 2019 23:13:39 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x15NDcFx2359776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Feb 2019 23:13:38 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3E664C070; Tue, 5 Feb 2019 23:13:37 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB9D34C064; Tue, 5 Feb 2019 23:13:36 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.107.43]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 5 Feb 2019 23:13:36 +0000 (GMT) Subject: Re: [PATCH] x86/ima: require signed kernel modules From: Mimi Zohar To: Luis Chamberlain Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , David Howells , Seth Forshee , Justin Forbes , Matthew Garrett Date: Tue, 05 Feb 2019 18:13:26 -0500 In-Reply-To: <20190205211337.GX11489@garbanzo.do-not-panic.com> References: <1548962339-10681-1-git-send-email-zohar@linux.ibm.com> <1548962339-10681-2-git-send-email-zohar@linux.ibm.com> <20190204203850.GP11489@garbanzo.do-not-panic.com> <1549317910.4146.124.camel@linux.ibm.com> <20190204223026.GR11489@garbanzo.do-not-panic.com> <1549369479.4146.142.camel@linux.ibm.com> <20190205211337.GX11489@garbanzo.do-not-panic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19020523-0028-0000-0000-00000344C60B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19020523-0029-0000-0000-00002402D098 Message-Id: <1549408406.4146.195.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-05_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=759 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902050169 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-02-05 at 13:13 -0800, Luis Chamberlain wrote: > Also, do we have selftests implemented to ensure we don't regress with > your changes? We're working on a regression test.  "modprobe" currently first attempts to use finit_module, and then falls back to using init_module.  Before writing a small program to load kernel modules, are you aware of any that allows you to specify the syscall? Mimi