Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   06 Feb 2019 09:50:51 +0900
Message-ID: <87lg2teon7.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Sakari Ailus <sakari.ailus@iki.fi>
Cc:     Yong Deng <yong.deng@magewell.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Chen-Yu Tsai <wens@csie.org>, <linux-media@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Niklas =?ISO-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@ragnatech.se>
Subject: Re: compile error at sun6i_video
In-Reply-To: <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk>
References: <878syukax3.wl-kuninori.morimoto.gx@renesas.com>
        <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk>
User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Sakari
Cc Niklas

Thank you for your feedback

> > /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_start_streaming':
> > /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:141:29: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types]
> >   ret = media_pipeline_start(&video->vdev.entity, &video->vdev.pipe);
> >                              ^~~~~~~~~~~~~~~~~~~
(snip)
> Do you have the patches Niklas's v4l2/mux (or my vc) branch in your tree?
> They change a few things on the way and drivers need to be converted.
> Drivers that have been added since the patches were written do need to be
> converted as well, and I suppose the sun6i_video driver is one of them.

I could find your branch at LinuxTV, and merged vc branch,
but unfortunately it can't solve compile issue.
I could understand its background.
It is OK for me if it will be solved on the next version.
I will skip it so far.
Thank you for your help

Best regards
---
Kuninori Morimoto