Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AXgvoCxTHS2ndkguJ1IfBDjhcu9psv+yvbD5Q0YIu?=
 =?us-ascii?q?jvd0So/mwa69bBaN2/xhgRfzUJnB7Loc0qyK6/CmATRIyK3CmUhKSIZLWR4BhJ?=
 =?us-ascii?q?detC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+?=
 =?us-ascii?q?KPjrFY7OlcS30P2594HObwlSizexfbB/IA+qoQnNq8IbnZZsJqEtxxXTv3BGYf?=
 =?us-ascii?q?5WxWRmJVKSmxbz+MK994N9/ipTpvws6ddOXb31cKokQ7NYCi8mM30u683wqRbD?=
 =?us-ascii?q?VwqP6WACXWgQjxFFHhLK7BD+Xpf2ryv6qu9w0zSUMMHqUbw5Xymp4rx1QxH0li?=
 =?us-ascii?q?gIKz858HnWisNuiqJbvAmhrAF7z4LNfY2ZKOZycqbbcNMfRGpBRd1RVy1HAoOz?=
 =?us-ascii?q?coABEfMPNvtWr4n8uVQOqQaxDhSoCO7h1jNEg3n71rA43es8CwHLxAwuEcwTvn?=
 =?us-ascii?q?rar9v7M7wfXfypwKTS0TnOde9a1Sv75YPVch4hu/aMXbdofMXTyEkuFgPFjkiX?=
 =?us-ascii?q?qYf4OD6U1uUMs2iB4OphSe6jl2Aqphpsojez3McgkJfGiZ8Iyl3d8yhy3YU7Jc?=
 =?us-ascii?q?WgRUJlfdKpFIFcuiKaOodsXM8uXm5ltDwnxrACu5O3ZDUGxZUjyhLFdfCKfYiF?=
 =?us-ascii?q?7gj9WOuQOzt1hn1odbSijBio60eg0PfzVsys3VZPqSpKj8fDu2gW1xzW9siHUv?=
 =?us-ascii?q?x9/lq92TqX1wDc9OVEIUcsmKreMZEhw7owmoMLsUTHAyP6gUv2gLKSe0gm4OSo?=
 =?us-ascii?q?5OPnYrLppp+YKYB4kB3xMqMrmsCnAOQ4NBYBX3SD9OiiyLHu+Vf1TbZKg/EsjK?=
 =?us-ascii?q?XVrZ/XKd4GqqO9AQJZyoMj5Ay+Dzei3tQYh34HLFdddROHjonpO0vBIPHkAfuj?=
 =?us-ascii?q?jVmhiypryOzcPrH7HJrCM2XDnK/7fblh805c1BYzzddH6pJQC7EBJu/zW0DouN?=
 =?us-ascii?q?zbEBA5KQq0zPjjCNhmyIMeVnyAArWDPKPRr1CI/OQvLPeIZIMPvzb9MfcltLbA?=
 =?us-ascii?q?l3g8zG4cb6m02tNDeWK4F/U+ex6xfHH2xNoNDDFZ7UIFUOX2hQjaAnZobHGoUv?=
 =?us-ascii?q?d5uWk2?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: [PATCH] phy: Variable "caldone" in function rockchip_emmc_phy_power() could be uninitialized
Date:   Tue,  5 Feb 2019 17:47:33 -0800
Message-Id: <20190206014733.21094-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function rockchip_emmc_phy_power(), local variable "caldone"
could be uninitialized if function regmap_read() returns -EINVAL.
However, it will be used directly in the later context, which
is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/phy/rockchip/phy-rockchip-emmc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c
index f1b24f18e9b2..ca921ae08309 100644
--- a/drivers/phy/rockchip/phy-rockchip-emmc.c
+++ b/drivers/phy/rockchip/phy-rockchip-emmc.c
@@ -85,11 +85,12 @@ struct rockchip_emmc_phy {
 static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
 {
 	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);
-	unsigned int caldone;
+	unsigned int caldone = 0;
 	unsigned int dllrdy;
 	unsigned int freqsel = PHYCTRL_FREQSEL_200M;
 	unsigned long rate;
 	unsigned long timeout;
+	int err;
 
 	/*
 	 * Keep phyctrl_pdb and phyctrl_endll low to allow
@@ -164,9 +165,14 @@ static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
 	 * wait 5us for calpad busy trimming
 	 */
 	udelay(5);
-	regmap_read(rk_phy->reg_base,
+	err = regmap_read(rk_phy->reg_base,
 		    rk_phy->reg_offset + GRF_EMMCPHY_STATUS,
 		    &caldone);
+	if (err) {
+		pr_err("Failed to read status.\n");
+		return err;
+	}
+
 	caldone = (caldone >> PHYCTRL_CALDONE_SHIFT) & PHYCTRL_CALDONE_MASK;
 	if (caldone != PHYCTRL_CALDONE_DONE) {
 		pr_err("rockchip_emmc_phy_power: caldone timeout.\n");
-- 
2.17.1