Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AeImxeBZhiuCfrPp0bqbJXq//LSx+4OfEezUN459i?=
 =?us-ascii?q?sYplN5qZoMS4bnLW6fgltlLVR4KTs6sC17KG9fi4EUU7or+5+EgYd5JNUxJXwe?=
 =?us-ascii?q?43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRp?=
 =?us-ascii?q?OOv1BpTSj8Oq3Oyu5pHfeQpFiCa+bL9oMBm6sRjau9ULj4dlNqs/0AbCrGFSe+?=
 =?us-ascii?q?RRy2NoJFaTkAj568yt4pNt8Dletuw4+cJYXqr0Y6o3TbpDDDQ7KG81/9HktQPC?=
 =?us-ascii?q?TQSU+HQRVHgdnwdSDAjE6BH6WYrxsjf/u+Fg1iSWIdH6QLYpUjm58axlVAHnhz?=
 =?us-ascii?q?sGNz4h8WHYlMpwjL5AoBm8oxBz2pPYbJ2JOPZ7eK7deNIaRXFaXsZQUSxBDZ63?=
 =?us-ascii?q?YZUWAeEcM+ZYrpfyp18TohCjAQWhCv/jxjpOi3Tr36M1zv4hHBnG0gI+AtwAvn?=
 =?us-ascii?q?faotLuOasOTey41rXEwC/fY/9K3zr29YjGcgomofGJRb9/c8vRyEgvFwPYiVWb?=
 =?us-ascii?q?tIvoPjOU1+QNqWeb7vZsWf6hhmM8tgF+viKvyt0yhYbUm4IY01bJ/jh6zoYtPd?=
 =?us-ascii?q?C0VlJ3bNq+HJZTtyyWLZV6Tt4+T21ypio21qEKtYamcCULzJkr3QDTZvKHfoSS?=
 =?us-ascii?q?/B7uVfydLDV3iX9jZbmxnQy98VK6xe35TsS01VFKoTdbndTUrXAN0gDT6tCASv?=
 =?us-ascii?q?tg4ketwTaP2B7X6uFDOU00kLDUK58lwrIpjpoTv1nPEjb4mEnokKOaal8o+uev?=
 =?us-ascii?q?6+TgbbXmooGTO5VohQH5N6Qigs2/AeImPQgSR2WX5/iw2bn58UD6QLhGlOM6nr?=
 =?us-ascii?q?TFvJzAO8gXurK1DxdQ0ok56ha/Czmm0M4fnXkCNF9EeBOGj4jzNFHPPPz0Efmy?=
 =?us-ascii?q?jk+xkDh33fDKJKPuDYjQLnTbirfuYa5961JAyAo01d1f45NUCrccIPP8Q0Pxt8?=
 =?us-ascii?q?LXDgU/MwOqx+bqE8t91owAVmKVGKOZM73dsUWO5u0xJ+mAfogVuCzyK6ttyeTp?=
 =?us-ascii?q?iCoImE0dYK7hiYoFaHm5Rqw9C1iSezzhjspXQjRChRY3UOG/0A7KajVUfXvnGv?=
 =?us-ascii?q?1k6w=3D=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhuyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Patrice Chotard <patrice.chotard@st.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized
Date:   Tue,  5 Feb 2019 19:12:57 -0800
Message-Id: <20190206031257.22494-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function miphy_osc_is_ready(), local variable "val"
could be uninitalized. if function regmap_read() returns
-EINVAL. However, this value is used in if statement.
This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/phy/st/phy-miphy28lp.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/st/phy-miphy28lp.c b/drivers/phy/st/phy-miphy28lp.c
index 213e2e15339c..40c7c0a611a0 100644
--- a/drivers/phy/st/phy-miphy28lp.c
+++ b/drivers/phy/st/phy-miphy28lp.c
@@ -835,7 +835,8 @@ static int miphy_osc_is_ready(struct miphy28lp_phy *miphy_phy)
 {
 	struct miphy28lp_dev *miphy_dev = miphy_phy->phydev;
 	unsigned long finish = jiffies + 5 * HZ;
-	u32 val;
+	u32 val = 0;
+	int ret;
 
 	if (!miphy_phy->osc_rdy)
 		return 0;
@@ -844,8 +845,10 @@ static int miphy_osc_is_ready(struct miphy28lp_phy *miphy_phy)
 		return -EINVAL;
 
 	do {
-		regmap_read(miphy_dev->regmap,
+		ret = regmap_read(miphy_dev->regmap,
 				miphy_phy->syscfg_reg[SYSCFG_STATUS], &val);
+		if (ret)
+			return ret;
 
 		if ((val & MIPHY_OSC_RDY) != MIPHY_OSC_RDY)
 			cpu_relax();
-- 
2.17.1