Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] phy: bcm-sr-pcie: Change operation when PIPEMUX=1
To:     Scott Branden <scott.branden@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>
CC:     <linux-kernel@vger.kernel.org>,
        <bcm-kernel-feedback-list@broadcom.com>,
        Qingmin Liu <qingmin.liu@broadcom.com>
References: <20190204190745.93170-1-ray.jui@broadcom.com>
 <ff198f05-41bb-2c4e-6d28-7a4c0960646e@broadcom.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <1575bf5c-7dff-6884-b2a2-5dcb5de4debd@ti.com>
Date:   Wed, 6 Feb 2019 17:46:15 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <ff198f05-41bb-2c4e-6d28-7a4c0960646e@broadcom.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 05/02/19 12:51 AM, Scott Branden wrote:
> Looks good.
> 
> On 2019-02-04 11:07 a.m., Ray Jui wrote:
>> From: Qingmin Liu <qingmin.liu@broadcom.com>
>>
>> When PIPEMIX=1, change the operation from 2x8 EP to 1x8 EP + 1x8 RC.
>>
>> Signed-off-by: Qingmin Liu <qingmin.liu@broadcom.com>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Acked-by: Scott Branden <scott.branden@broadcom.com>

merged, thanks.

-Kishon
>> ---
>>   drivers/phy/broadcom/phy-bcm-sr-pcie.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> index c10e95f86de5..96a3af126a78 100644
>> --- a/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> +++ b/drivers/phy/broadcom/phy-bcm-sr-pcie.c
>> @@ -78,8 +78,8 @@ struct sr_pcie_phy_core {
>>   static const u8 pipemux_table[] = {
>>       /* PIPEMUX = 0, EP 1x16 */
>>       0x00,
>> -    /* PIPEMUX = 1, EP 2x8 */
>> -    0x00,
>> +    /* PIPEMUX = 1, EP 1x8 + RC 1x8, core 7 */
>> +    0x80,
>>       /* PIPEMUX = 2, EP 4x4 */
>>       0x00,
>>       /* PIPEMUX = 3, RC 2x8, cores 0, 7 */