Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190131082308.22522-1-stefan@olimex.com> <20190131082308.22522-5-stefan@olimex.com>
 <CAGb2v66B3X=hyCCanUv6yGziVcu3WrRcKODBp266ODL+yQ4m1w@mail.gmail.com> <4493d1cb-d1bb-bcc9-c37d-68c79f33e762@olimex.com>
In-Reply-To: <4493d1cb-d1bb-bcc9-c37d-68c79f33e762@olimex.com>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Wed, 6 Feb 2019 21:10:33 +0800
Message-ID: <CAGb2v65Pj4Xd9+faBZ7d9OorWrDFZmtUaH8MFq5WO29x+OhYXA@mail.gmail.com>
Subject: Re: [PATCH 5/5] arm: dts: axpxx: add charge led node
To:     Stefan Mavrodiev <stefan@olimex.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS" 
        <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 6, 2019 at 2:06 PM Stefan Mavrodiev <stefan@olimex.com> wrote:
>
>
> On 2/5/19 6:16 PM, Chen-Yu Tsai wrote:
> > On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev <stefan@olimex.com> wrote:
> >> Add dt node for axp20x-led driver controlling CHGLED.
> >> Default status is disabled, since it may be not used.
> >>
> >> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> > Please include a cover letter for such a patch series.
> Sorry, I will.
> >
> > Also, do any boards actually use this? I know the Pine64 does, but the
> > LED is left to the user to populate. I would really like to have an in
> > kernel user of this function, so that we can verify it.
>
> All boards made by Olimex has this led populated. The development and the
> testing of the driver was done on A64-OLinuXino board.
>
> Should I make another patch, enabling the LED for the mention board?

Yes please. I'll dig out my A33-OLinuXino next week to try it out.

ChenYu

> >
> > ChenYu
> >
> >> ---
> >>   arch/arm/boot/dts/axp209.dtsi | 5 +++++
> >>   arch/arm/boot/dts/axp22x.dtsi | 5 +++++
> >>   arch/arm/boot/dts/axp81x.dtsi | 5 +++++
> >>   3 files changed, 15 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> >> index 0d9ff12bdf28..f972b6f3ecd0 100644
> >> --- a/arch/arm/boot/dts/axp209.dtsi
> >> +++ b/arch/arm/boot/dts/axp209.dtsi
> >> @@ -69,6 +69,11 @@
> >>                  #gpio-cells = <2>;
> >>          };
> >>
> >> +       axp_led: led {
> >> +               compatible = "x-powers,axp20x-led";
> >> +               status = "disabled";
> >> +       };
> >> +
> >>          battery_power_supply: battery-power-supply {
> >>                  compatible = "x-powers,axp209-battery-power-supply";
> >>                  status = "disabled";
> >> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
> >> index 65a07a67aca9..92a0b64252b1 100644
> >> --- a/arch/arm/boot/dts/axp22x.dtsi
> >> +++ b/arch/arm/boot/dts/axp22x.dtsi
> >> @@ -62,6 +62,11 @@
> >>                  #io-channel-cells = <1>;
> >>          };
> >>
> >> +       axp_led: led {
> >> +               compatible = "x-powers,axp20x-led";
> >> +               status = "disabled";
> >> +       };
> >> +
> >>          battery_power_supply: battery-power-supply {
> >>                  compatible = "x-powers,axp221-battery-power-supply";
> >>                  status = "disabled";
> >> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> >> index bd83962d3627..22e243cc40d5 100644
> >> --- a/arch/arm/boot/dts/axp81x.dtsi
> >> +++ b/arch/arm/boot/dts/axp81x.dtsi
> >> @@ -74,6 +74,11 @@
> >>                  };
> >>          };
> >>
> >> +       axp_led: led {
> >> +               compatible = "x-powers,axp20x-led";
> >> +               status = "disabled";
> >> +       };
> >> +
> >>          battery_power_supply: battery-power-supply {
> >>                  compatible = "x-powers,axp813-battery-power-supply";
> >>                  status = "disabled";
> >> --
> >> 2.17.1
> >>