Received: by 2002:ac0:8c8e:0:0:0:0:0 with SMTP id r14csp618929ima; Wed, 6 Feb 2019 05:46:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ71V7kd+rgM55g6OqROY+nBnOxrR1Nw8aKWnGdDHXIP+SBc0HfYjXMcJroN9Jrp53J/gH6 X-Received: by 2002:a65:609a:: with SMTP id t26mr9456569pgu.411.1549460788458; Wed, 06 Feb 2019 05:46:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549460788; cv=none; d=google.com; s=arc-20160816; b=X+NKOcdOXL2QsA63Eml3oqvnN1sGRjG1TtD1I1/UT/h9cUx846dTI3sAndKLXE6Gj9 Pf49D3z1MivOKuCrd3gsPKKHrAP5uMh9xFW+tIqBcJOH4XqRidicXQb2xVZZWct4uCa8 BaaHaO2kdiduHQUwvTPO9+wkaRJQT1nXWtaP98TlGoV1gYk1jmTEWVNHru3YMLP6TAAd MuEaoBqFAQ89OAf+F64ByBHEVJRcGTvhXUfuLewzWZuBwi7TKKJSgvcLUry1wF49oAIK QeVFzra7ExIfIqZRgY0qumsldhcs/8+g5oZRGYC2nk6ZDA+Zh9AJMcBM9CD43j4bGhge 1ROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1B0x+fHheTpxhqrmIHIXM2dJK3tS381uY73XT9HFqos=; b=uYT5mObqhooa+Mfj4XXeOCO/nnh6/52dFoMQEKVcpGELtnRnhWT/qqA3oxTMVlqaHb np+BG4L4ByGIp6pk48trTtMq1TCyBfbLqrywp8YC3PHQ+Zw0YRG5cjo+3dhat9ej+rOo 3q3fAJsHPXa0scJlmlHln1Ahaa4VJftpVug6bFJCkDUVn1m73Wi2O0CQ7Qx3skpjJ7c7 r/v+h9uQTaECrqc7WhUffQCOsa4k7i4mNpvgbEkjYl5nSAq1DzBRayKXsNFSg7HYTpKD NoDG21v4zxcSs0zPiYGRUhAtdFxaWq47L8oTiazdpXxmMcF6pPgwj78uQrIMk1WsHwNl m89A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=qPpxYV8G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si2488425pgr.252.2019.02.06.05.46.13; Wed, 06 Feb 2019 05:46:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=qPpxYV8G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730634AbfBFNpl (ORCPT + 99 others); Wed, 6 Feb 2019 08:45:41 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.167]:22054 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729369AbfBFNpk (ORCPT ); Wed, 6 Feb 2019 08:45:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1549460737; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=1B0x+fHheTpxhqrmIHIXM2dJK3tS381uY73XT9HFqos=; b=qPpxYV8GUTFC2EfNpbLucQltqtQbs5JgNkL2piJqqheHDXeG7Y12ty84GvFWHK5oJz NrlQ48lOyE5BHDDm8jd8N3MEBcHIwpweoAXkysrBr/42dwkzZiqCJCOY9o7cZB1/oCQn t4M3vmTDo9Jqhyl067mQTLE2ka1X+Br2gbTJguWxOlD4vkkAppKLa9uPApjlkgn2MZYi hp96BmHnpnkYJJnm2+hAsxXN9dwL0zXm5qztQyBIQbaM9vRdp060Z+LB9aJAzSZpk/7F qkQHfA2XnBHfhNlQZRqt/nSNJt2taqHUrnagSRwf6J57MVyyKTE8ZCOVRz5Fcmollosn ylMg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5G5MdirQj0WG7ClZjqpXztc6Zcqs1wHF7xyXswVRvQ==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:a400:162c:f029:5369:8d3a:5beb] by smtp.strato.de (RZmta 44.9 AUTH) with ESMTPSA id t0203dv16DjYum1 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 6 Feb 2019 14:45:34 +0100 (CET) Subject: Re: use generic DMA mapping code in powerpc V4 To: Christoph Hellwig , Olof Johansson Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org References: <6f2d6bc9-696b-2cb1-8a4e-df3da2bd6c0a@xenosoft.de> <20190129161411.GA14022@lst.de> <20190129163415.GA14529@lst.de> <96762cd2-65fc-bce5-8c5b-c03bc3baf0a1@xenosoft.de> <20190201080456.GA15456@lst.de> <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> From: Christian Zigotzky Message-ID: Date: Wed, 6 Feb 2019 14:45:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190204123852.GA10428@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04 February 2019 at 01:38PM, Christoph Hellwig wrote: > > It seems like the pasemi driver fails to set a DMA mask, but seems > otherwise 64-bit DMA capable. The old PPC code didn't verify the > dma mask during the map operations, but the x86-derived generic > code does. > > This patch just sets the DMA mask. > > Olof: does this look ok? The DMA device seems to not directly > bound by the net driver, but not really used by anything else in tree > either.. > > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c > index d21041554507..d98bd447c536 100644 > --- a/drivers/net/ethernet/pasemi/pasemi_mac.c > +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c > @@ -1716,6 +1716,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > err = -ENODEV; > goto out; > } > + dma_set_mask(&mac->dma_pdev->dev, DMA_BIT_MASK(32)); > > mac->iob_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa001, NULL); > if (!mac->iob_pdev) { > Hello Christoph, I patched the source code from the Git 'powerpc-dma.6' with your patch today. Unfortunately the P.A. Semi Ethernet doesn't work with the patched Git kernel. After that I tried it with the patch applied over the working setup again (powerpc/dma: use the dma_direct mapping routines). Unfortunately after compiling and booting, the P.A. Semi Ethernet doesn't work either. Cheers, Christian