Received: by 2002:ac0:8c8e:0:0:0:0:0 with SMTP id r14csp744397ima; Wed, 6 Feb 2019 07:41:37 -0800 (PST) X-Google-Smtp-Source: AHgI3IYf3pXECSFTIh3qYmbvYIt44dqv4NzEmp8Oarvun0H2U8sK80rP1Ctt6HscfzTt46W8Wc44 X-Received: by 2002:a63:454a:: with SMTP id u10mr9687358pgk.224.1549467696973; Wed, 06 Feb 2019 07:41:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549467696; cv=none; d=google.com; s=arc-20160816; b=Bjub+J8R5E64O8AmP/08lY70r1ciOhXsiEp1HUeGdHtHm26fOR4ZGy/b/vwgV0l9Ql N+gdi+qfyKSMli019AXgDWVDkZtu5AA+4iCVynsZ16eJ6oGFdkTNUtp/WAAvnyPUrJGM GrvefOa+braeVbem8Q4JVTMM0rR536BU6GFoOqEk+ywIBsjwGu3hgum7iaAI+NykVpHD bDHENar66ZYOXCvQZPdtwR3PXmXS+a5XjIf79d4i07ufOcdPxBnOD1Iu/qYKPXGUQnwE y66T6vPuC3+74NwDGzdLtTojNJ48oB+DFEbF95Uqymx6bZMEzEGWmlayYVr+3IdDx1IU kOLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nYJdAt1bpCQZ+/cOdHZDT2KaGwiu6NTGMoOXA7EZqmI=; b=CpP01u9zyANRlNufq0/w8rmzvyk65OKobQFipBy4wlJL0/70+0uIeI9wjYIJ+bhtZs arqC+XDH70DT3KdbCaCj7n2LftSkqrv1BoT7dWQ85UNacvyE6Oopsh7fZBRar15AcPQG X2yLY526gW/swRRMXfd0ZmJ/XYmyMWxP4jgzj3+q2zMVjLKPSJNoflYgCb24o6IERhkC RhKa8WqyrPdwe5CafUX1r+NbwENgQXhHEIpPWgiJIERxWSlRByNdIKfGjHYLsccT+uO0 W/TgQZ8CUmOf70KKprppJrKwameXoFzHrWYI+pjZc2CcaI4Dc3+hl1g/BMaB5sf3jqMJ 9XLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si6660029pfu.273.2019.02.06.07.41.21; Wed, 06 Feb 2019 07:41:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730567AbfBFPQ5 (ORCPT + 99 others); Wed, 6 Feb 2019 10:16:57 -0500 Received: from verein.lst.de ([213.95.11.211]:60214 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726726AbfBFPQ4 (ORCPT ); Wed, 6 Feb 2019 10:16:56 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 4EF4F68D93; Wed, 6 Feb 2019 16:16:55 +0100 (CET) Date: Wed, 6 Feb 2019 16:16:55 +0100 From: Christoph Hellwig To: Christian Zigotzky Cc: Christoph Hellwig , Olof Johansson , linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: use generic DMA mapping code in powerpc V4 Message-ID: <20190206151655.GA31172@lst.de> References: <96762cd2-65fc-bce5-8c5b-c03bc3baf0a1@xenosoft.de> <20190201080456.GA15456@lst.de> <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> <20190206151505.GA31065@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206151505.GA31065@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 06, 2019 at 04:15:05PM +0100, Christoph Hellwig wrote: > The last good one was 29e7e2287e196f48fe5d2a6e017617723ea979bf > ("dma-direct: we might need GFP_DMA for 32-bit dma masks"), if I > remember correctly. powerpc/dma: use the dma_direct mapping routines > was the one that you said makes the pasemi ethernet stop working. > > Can you post the dmesg from the failing runs? But I just noticed I sent you a wrong patch - the pasemi ethernet should set a 64-bit DMA mask, not 32-bit. Updated version below, 32-bit would just keep the previous status quo. commit 6c8f88045dee35933337b9ce2ea5371eee37073a Author: Christoph Hellwig Date: Mon Feb 4 13:38:22 2019 +0100 pasemi WIP diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c index 8a31a02c9f47..2d7d1589490a 100644 --- a/drivers/net/ethernet/pasemi/pasemi_mac.c +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c @@ -1716,6 +1716,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err = -ENODEV; goto out; } + dma_set_mask(&mac->dma_pdev->dev, DMA_BIT_MASK(64)); mac->iob_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa001, NULL); if (!mac->iob_pdev) {