Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Yizhuo <yzhai003@ucr.edu>
In-Reply-To: <20190127051012.5928-1-yzhai003@ucr.edu>
User-Agent: alot/0.8
Subject: Re: [PATCH] clk: gemini: Variable "val" in function gemini_clk_probe() could be uninitialized
Message-ID: <154948099918.115909.13787183177670759883@swboyd.mtv.corp.google.com>
References: <20190127051012.5928-1-yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Stephen Boyd <sboyd@kernel.org>
Date:   Wed, 06 Feb 2019 11:23:19 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Yizhuo (2019-01-26 21:10:12)
> In function gemini_clk_probe(), local variable "val" could
> be uninitialized if function regmap_read() returns -EINVAL.
> However, it will be used as index in the later context, which
> could potentially be unsafe.

Ok. How did you find this? Any pointers?

>=20
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---
>  drivers/clk/clk-gemini.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

There are other locations in this file where 'val' is used even if
regmap_read() fails. For example gemini_pci_recalc_rate() does this. Can
you fix all the callers in this file? Presumably nobody cares that this
API could fail in this driver because it's a thin wrapper around mmio
read that never fails. Maybe we could have a comment instead that this
is the case and then ignore this patch entirely.