Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Feb 2019 11:26:23 -0800
From:   Benson Leung <bleung@google.com>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     linux-kernel@vger.kernel.org, groeck@chromium.org,
        lee.jones@linaro.org, gwendal@chromium.org, kernel@collabora.com,
        bleung@chromium.org, Guenter Roeck <linux@roeck-us.net>,
        bleung@google.com
Subject: Re: [PATCH v2] mfd: cros_ec_dev: Return number of bytes read with
 CROS_EC_DEV_IOCRDMEM
Message-ID: <20190206192623.GA120245@google.com>
References: <20190206173959.23925-1-enric.balletbo@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP"
Content-Disposition: inline
In-Reply-To: <20190206173959.23925-1-enric.balletbo@collabora.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--jRHKVT23PllUwdXP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 06, 2019 at 06:39:59PM +0100, Enric Balletbo i Serra wrote:
> From: Guenter Roeck <linux@roeck-us.net>
>=20
> While ioctls normally return a negative error or 0 on success, this is not
> the case for CROS_EC_DEV_IOCXCMD in the cros_ec driver, which returns the
> number of bytes read instead. However, CROS_EC_DEV_IOCRDMEM in the same
> driver does not return the number of byte read on success. This is both
> inconsistent and problematic, since the amount of returned data can be
> dynamic. Have it return the number of data bytes for consistency.
>=20
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
> Hi,
>=20
> This patch was send long time ago and never landed to mainline [1]. This
> is a second attempt. Originally was made to apply on platform/chrome but
> after the recent changes we did it should go now throught the MFD
> subsystem. Without this patch userspace tools like ectool doesn't work
> as expected.
>=20
> Best regards,
>  Enric
>=20
> [1] https://lore.kernel.org/patchwork/patch/665211/
>=20
> Changes in v2:
> - Adapt and rebase to current mainline.
>=20
>  drivers/mfd/cros_ec_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index ed809fc97df8..d275deaecb12 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -224,7 +224,7 @@ static long ec_device_ioctl_readmem(struct cros_ec_de=
v *ec, void __user *arg)
>  	if (copy_to_user((void __user *)arg, &s_mem, sizeof(s_mem)))
>  		return -EFAULT;
> =20
> -	return 0;
> +	return num;
>  }
> =20
>  static long ec_device_ioctl(struct file *filp, unsigned int cmd,
> --=20
> 2.20.1
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--jRHKVT23PllUwdXP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlxbNN8ACgkQHwn1ewov
5lgNJBAAqEKRzL1S4HrmJhITKNnok8q/Fq2WhLjJwISymscAjOqsu5EJpiQMC5A2
mCj7dY2H2LtD3Roi5ubOY+MrZFCsGj1NKUEqUwdjs0j0sEmvcJ63GK2YyBKrWPDR
BCUod0IO/2zcE7Q0tdIpBo4YZAd8iYihUGsPdKQ+HUDqPqqHYsUKPUwn9Pcqfxzx
iI70xep8kB8vZiFdF+mVLLlFjHptn9d2YWW7ZR2+vWynBgQKowcGEzdv4i1bvueu
7WHIV9Iz1L8p4e/vcnn1k9/A+P4qYhE3hy9H0n130UUIgTK080tIb2075zUNuXLM
qxitZxZvtznMpEz/pjsm5uacBkWUlshWsEkscTBKCW+YAbWO7jDCO1Zurv72EebC
jn3EML6bzk0NjPEuKQgcX3lMc46ZpOmKn1yH9AE61NCdpoMBFZjgR2N9jx5mi2sl
RGB3ikU82VKPBv1oqWbjPtp2jB6Na0LY8aJhP/OyxndZX2rZ4cHwVoDoWIkiAkik
Ry9IehUvevKM5xGBoQniP9/XUFq/QVuP1I4xidvBK9iFZ+bxNYMyLOm3pO8a9mYg
oBcnnvQN53EaI7/RKQZk32XoL478qVUi/6RVviOzK+AlQq8QACaj8m2Lubq9VsJo
+SA7A8et56Umud+qpK2S21m5GYG1d++nXRYmfmvaabWZzUCf9NA=
=bLFI
-----END PGP SIGNATURE-----

--jRHKVT23PllUwdXP--