Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Julien Freche <jfreche@vmware.com>
Subject: Re: [PATCH 1/6] vmw_balloon: bump version number
Thread-Topic: [PATCH 1/6] vmw_balloon: bump version number
Thread-Index: AQHUvdqzIjtzT9t97UifPzgt+4rp6aXS+kOAgABCQAA=
Date:   Wed, 6 Feb 2019 20:39:52 +0000
Message-ID: <83759B2D-329A-4CBA-84A4-0511398D1AB2@vmware.com>
References: <20190206051336.2425-1-namit@vmware.com>
 <20190206051336.2425-2-namit@vmware.com> <20190206164245.GA8466@kroah.com>
In-Reply-To: <20190206164245.GA8466@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2FD52567B443DE47B770F60308387EB3@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 835c3088-c753-4036-e2e8-08d68c733f4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2019 20:39:52.9354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5665
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.or=
g> wrote:
>=20
> On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
>> Following recent changes.
>>=20
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> drivers/misc/vmw_balloon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index f8240b87df22..7294f305753f 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -34,7 +34,7 @@
>>=20
>> MODULE_AUTHOR("VMware, Inc.");
>> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
>> -MODULE_VERSION("1.5.0.0-k");
>> +MODULE_VERSION("1.6.0.0-k");
>=20
> Please just drop this pointless line, it means nothing and is always out
> of date.  It's been removed from many other drivers, and I really don't
> want to see it come back.
>=20
> Your driver "version" is the kernel version, full stop.  That's all you
> need to ever worry about.

I understand, and I will inform those who asked for the version bump.

Having said that, I do not see a reference for this policy. I understand
that you removed the MODULE_VERSION from in-kernel drivers, but I also see
that you accepted several drivers last year that used MODULE_VERSION.