Received: by 2002:ac0:8c8e:0:0:0:0:0 with SMTP id r14csp2910ima; Wed, 6 Feb 2019 15:59:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IZmB2k7wLav+EUgVfYniDFq2KlgOtgoybuVpj72ooed5v70I8FoOthCCbv90DYlFa5VA8pY X-Received: by 2002:a17:902:128c:: with SMTP id g12mr13003503pla.146.1549497540189; Wed, 06 Feb 2019 15:59:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549497540; cv=none; d=google.com; s=arc-20160816; b=xh6hxzb5bkARvXunhbj1fzmFzy1aHkrsuosffKlGCpXGWMUtf6xuzCe6MAKGxNxb4s 7Cwhwr8Ug/W05M+RKuxyxQNVcrxrMuCNIP5E7lkO4eeK/nmZLC3i0WUEmCmWDZHCWQTI l1a9l4W3yay80LBiak1XlXaEFY+wSUKK6vXIkcGZk0zIwrGDfR0BsHn9wnk9/VGLKltd WvbFVD+PDURTdzDJWMeSGSyfFmDcUWFtH3JfPA2UAg6WelDAzKCF3Xg1tPUD/LChAjkG 6CpcSGcx2cXlukVMx6KRkclvKXRAy61dXpm2Np9zMBuxJl1CTUZsW52E2tBrvxLWl/sk 9Tvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=RQo0r55ep+IFxClsvUwVUcoj8kzkmEfppGh4cRVY2Nw=; b=jBWIGv3JHOcxpLR+kgLVIBNwnWchfBiYREO8+KVUOd/lU4A4wsPE31IpQsn0VPAqCn 61yMS9qMMp1M5KWVVJ8uFRByLysZ8pkdONV9pe13wX8XdF8DmjxjDBBikUklq842Kd4+ YXsfCcwKNWUlsGb64pmGxCQr6b2TWR+5RrK5RIHEZyzHz7T3569cp+dVigOKjPe0B6ow gaGnOHcYzA1pGQ1KBC8UDnXAkqpBs83VHgNvy2RckCtFXSs2iiYJVeJ7ZWICoWJM31MX dc4eQB7Zlxrescsa5mSBmt+mj4ww+uM3vhPq6ybvJW4EGxBw4HdLPZWPozBunzCqDex2 K0wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ba9si6998557plb.109.2019.02.06.15.58.44; Wed, 06 Feb 2019 15:59:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbfBFX5i (ORCPT + 99 others); Wed, 6 Feb 2019 18:57:38 -0500 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:7669 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfBFX5N (ORCPT ); Wed, 6 Feb 2019 18:57:13 -0500 Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP Server id 15.0.1156.6; Wed, 6 Feb 2019 15:56:24 -0800 Received: from ubuntu.localdomain (unknown [10.33.115.182]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id A9E4D40FC9; Wed, 6 Feb 2019 15:57:11 -0800 (PST) From: Nadav Amit To: Greg Kroah-Hartman CC: Arnd Bergmann , , Julien Freche , Nadav Amit Subject: [PATCH 2/6] vmw_balloon: support 64-bit memory limit Date: Wed, 6 Feb 2019 15:57:02 -0800 Message-ID: <20190206235706.4851-3-namit@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190206235706.4851-1-namit@vmware.com> References: <20190206235706.4851-1-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX13-EDG-OU-001.vmware.com: namit@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xavier Deguillard Currently, the balloon driver would fail to run if memory is greater than 16TB of vRAM. Previous patches have already converted the balloon target and size to 64-bit, so all that is left to do add is to avoid asserting memory is smaller than 16TB if the hypervisor supports 64-bits target. The driver advertises a new capability VMW_BALLOON_64_BITS_TARGET. Hypervisors that support 16TB of memory or more will report that this capability is enabled. Signed-off-by: Xavier Deguillard Signed-off-by: Nadav Amit --- drivers/misc/vmw_balloon.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index c4371ec132d3..f96dc3690ade 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -72,15 +72,26 @@ enum vmwballoon_capabilities { VMW_BALLOON_BATCHED_CMDS = (1 << 2), VMW_BALLOON_BATCHED_2M_CMDS = (1 << 3), VMW_BALLOON_SIGNALLED_WAKEUP_CMD = (1 << 4), + VMW_BALLOON_64_BIT_TARGET = (1 << 5) }; -#define VMW_BALLOON_CAPABILITIES (VMW_BALLOON_BASIC_CMDS \ +#define VMW_BALLOON_CAPABILITIES_COMMON (VMW_BALLOON_BASIC_CMDS \ | VMW_BALLOON_BATCHED_CMDS \ | VMW_BALLOON_BATCHED_2M_CMDS \ | VMW_BALLOON_SIGNALLED_WAKEUP_CMD) #define VMW_BALLOON_2M_ORDER (PMD_SHIFT - PAGE_SHIFT) +/* + * 64-bit targets are only supported in 64-bit + */ +#ifdef CONFIG_64BIT +#define VMW_BALLOON_CAPABILITIES (VMW_BALLOON_CAPABILITIES_COMMON \ + | VMW_BALLOON_64_BIT_TARGET) +#else +#define VMW_BALLOON_CAPABILITIES VMW_BALLOON_CAPABILITIES_COMMON +#endif + enum vmballoon_page_size_type { VMW_BALLOON_4K_PAGE, VMW_BALLOON_2M_PAGE, @@ -571,8 +582,9 @@ static int vmballoon_send_get_target(struct vmballoon *b) limit = totalram_pages(); - /* Ensure limit fits in 32-bits */ - if (limit != (u32)limit) + /* Ensure limit fits in 32-bits if 64-bit targets are not supported */ + if (!(b->capabilities & VMW_BALLOON_64_BIT_TARGET) && + limit != (u32)limit) return -EINVAL; status = vmballoon_cmd(b, VMW_BALLOON_CMD_GET_TARGET, limit, 0); -- 2.17.1