Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190122233749.42220-1-trong@android.com>
In-Reply-To: <20190122233749.42220-1-trong@android.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Wed, 6 Feb 2019 16:52:58 -0800
Message-ID: <CAKwvOdm1+P-8YqtgZV65EAMnVN-n1mkpOOX0yp-qEbuCH5F9Rw@mail.gmail.com>
Subject: Re: [PATCH v3 0/3] gcov: add Clang support
To:     Peter Oberparleiter <oberpar@linux.ibm.com>
Cc:     Greg Hackmann <ghackmann@android.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Tri Vo <trong@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 22, 2019 at 3:38 PM Tri Vo <trong@android.com> wrote:
>
> This patch series adds Clang supoprt for gcov.
>
> Patch 1 refactors existing code in preparation for Clang support.
> Patch 2 implements necessary LLVM runtime hooks and gcov kernel interfaces.
> Patch 3 updates documentation.
>
> Greg Hackmann (2):
>   gcov: Clang: move common GCC code into gcc_base.c
>   gcov: Clang support
>
> Tri Vo (1):
>   gcov: docs: add a note on GCC vs Clang differences
>
>  Documentation/dev-tools/gcov.rst |  18 +-
>  kernel/gcov/Kconfig              |   3 +-
>  kernel/gcov/Makefile             |   5 +-
>  kernel/gcov/base.c               |  84 +----
>  kernel/gcov/clang.c              | 555 +++++++++++++++++++++++++++++++
>  kernel/gcov/gcc_base.c           |  86 +++++
>  kernel/gcov/gcov.h               |   3 +
>  7 files changed, 665 insertions(+), 89 deletions(-)
>  create mode 100644 kernel/gcov/clang.c
>  create mode 100644 kernel/gcov/gcc_base.c
>
> v2:
> - Reorganized config dependencies, as per Masahiro.
>
> v3:
> - Squashed patches 2-4 of v2, as per Nick, Masahiro, and Peter.
> Addressed comments by Peter:
> - Moved __gcov_exit() to gcc_base.c
> - Added missing header to gcc_base.c
> - Removed unnecessary boundary checks in gcov_info_add().
> - Changed counters' allocation to use vmalloc().
> - Added check for failed allocation of filename.
> - Changed list_for_each_entry_safe to list_for_each_entry when traversing
>   without modifying.
> - Updated Documentation/dev-tools/gcov.rst
>
> --
> 2.20.1.321.g9e740568ce-goog
>

Bumping this thread for review.

-- 
Thanks,
~Nick Desaulniers