Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Feb 2019 14:03:05 +1100
From:   David Gibson <david@gibson.dropbear.id.au>
To:     Laurent Vivier <lvivier@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        linuxppc-dev@lists.ozlabs.org,
        Christophe Leroy <christophe.leroy@c-s.fr>
Subject: Re: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug()
Message-ID: <20190207030305.GA518@umbus.fritz.box>
References: <20190205202133.5048-1-lvivier@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
In-Reply-To: <20190205202133.5048-1-lvivier@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 05, 2019 at 09:21:33PM +0100, Laurent Vivier wrote:
> resize_hpt_for_hotplug() reports a warning when it cannot
> increase the hash page table ("Unable to resize hash page
> table to target order") but this is not blocking and
> can make user thinks something has not worked properly.
> As we move the message to the debug area, report again the
> ENODEV error.
>=20
> If the operation cannot be done the real error message
> will be reported by arch_add_memory() if create_section_mapping()
> fails.
>=20
> Fixes: 7339390d772dd
>        powerpc/pseries: Don't give a warning when HPT resizing isn't avai=
lable
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Sorry, I'm pretty dubious about this.  It's true that in the case for
which this bug was filed this is a harmless situation which deserves a
pr_debug() at most.

But that's not necessarily true in all paths leading to this message.
It will also trip if we fail to reshrink the HPT after genuinely
hotunplugging a bunch of memory, in which case failing to release
expected resources does deserve a warning.

> ---
>=20
> Notes:
>     v2:
>      - use pr_debug instead of printk(KERN_DEBUG
>      - remove check for ENODEV
>=20
>  arch/powerpc/mm/hash_utils_64.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils=
_64.c
> index 0cc7fbc3bd1c..6a0cc4eb2c83 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -777,10 +777,9 @@ void resize_hpt_for_hotplug(unsigned long new_mem_si=
ze)
>  		int rc;
> =20
>  		rc =3D mmu_hash_ops.resize_hpt(target_hpt_shift);
> -		if (rc && (rc !=3D -ENODEV))
> -			printk(KERN_WARNING
> -			       "Unable to resize hash page table to target order %d: %d\n",
> -			       target_hpt_shift, rc);
> +		if (rc)
> +			pr_debug("Unable to resize hash page table to target order %d: %d\n",
> +				 target_hpt_shift, rc);
>  	}
>  }
> =20

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlxbn+cACgkQbDjKyiDZ
s5L2uA//d3kL73x/E6LZ0sRh7aylcIfnRBlPzYmX787L4LZfSSlFGDscIhjj4EWx
cWArmrwR62zv2H9pcgj2oKz9C1cZQPfC8wHTJuAOPiRb8oVWic1KysbJhDLPfeRp
LwoCoocxdob69Li45NysjHTEtnoBKt9flllkNcieyPRz92mhCdYiTyjyuVkyg9hd
Sl2EXEqZpt+eq2+vr3l26nC0Y4IdgzmnY8GqELpbqhLCWX7XXvokUrx8uXfxzCc+
xHiE72FQhtTcj3aShI1DYt8doJFVUP0i5441UhQUImQzahC3Oo8i7N3kRJfcZNYd
S75JnBrm0RAzd4jOyRsqiDADeDqjPhzo4Hq7D3i5KMKT2pHa37VUEmCRIGYEjpea
A9aYlhVbdvDdCyy5LQs/6/A6FNk8pfccNMCG8AxStR7cYQdo8Babz+F4jutfigTB
F+ZBtFWmAwvKE18ClErfOzE+GgOHvh2FIWLH2biwArPEc7PON9VzaWP8K41CQEfs
9zJjvEgp4fofadFimPr2hUmkfvWmngy+6vbHm48Y/kdf6LnEBIlS+322YncEalTW
ABKAllKMxkYxXig6ORHwBW8j+wGCRM+dYvPJ2ZFwspGxWXIzMkKIeD9YhUiP/mvN
4ZXSy1mt1IFikkgfko2u/yCSzsR9/WYC7M7j1gXBTlI1FuflB/M=
=UPqI
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--