Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 06 Feb 2019 20:17:36 -0800 (PST)
Message-Id: <20190206.201736.1146228626076916564.davem@davemloft.net>
To:     yzhai003@ucr.edu
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, peppe.cavallaro@st.com,
        alexandre.torgue@st.com, maxime.ripard@free-electrons.com,
        wens@csie.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190205221559.17545-1-yzhai003@ucr.edu>
References: <20190205221559.17545-1-yzhai003@ucr.edu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yizhuo <yzhai003@ucr.edu>
Date: Tue,  5 Feb 2019 14:15:59 -0800

> @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv)
>  	struct sunxi_priv_data *gmac = priv->plat->bsp_priv;
>  	struct device_node *node = priv->device->of_node;
>  	int ret;
> -	u32 reg, val;
> +	u32 reg, val = 0;
> +
> +	ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val);
> +	if (ret) {
> +		dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n");
> +		return ret;
> +	}

I agree with the other reviewer that since you check 'ret' the initialization of
'val' is no longer needed.