Received: by 2002:ac0:8bc7:0:0:0:0:0 with SMTP id o7csp44375ima; Wed, 6 Feb 2019 20:37:25 -0800 (PST) X-Google-Smtp-Source: AHgI3IbK+asMA2rh590DIHHhM3mN+wDcHuLM0zk2QQslMjP60OS8UrzFmHwiQBqZbNl14YziAmkE X-Received: by 2002:a62:1b50:: with SMTP id b77mr14325902pfb.36.1549514245513; Wed, 06 Feb 2019 20:37:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549514245; cv=none; d=google.com; s=arc-20160816; b=nBLqwcku5xcvgNyjGSOPPDyn4VYlMHn1u8HY6zCvtbz6SLt7g8hU1H5ySIj5zSxAqP 132qXdEvnRR3CMjZrrwE7WrBGuCt7btQpgMkGph3caV24yADAPhyx2At9SsRMPRSsFix NemU7ooV9kIzeUDUeBUHld9NVllKuAZ/3drQ0tJ97gQMIbt2RUsxnaOF7AIT5Ap19Z/8 9dNY1fldlPl0VZI/xgxY17I3+OuRUnC54tb3/npI87pFjHBj9W7HkGb8Bz0YMf5CsQ2M ZuBg+FWIvpkoqUYNTSV21HjjTGsBaNr/ZCBsvCJx0ydKOm0zS/4w9XoZ7zuBvFPM2XB/ yHmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=4RCZJtim6FzAWTAE5STy48t7VfnqZ8YM7yrGj0CnzHY=; b=lSgBOJu6TCBmysCnKTUBzTbDpL2qhaDPv5IwUSL6ZBxnotkOFKKaCsjk2U7forEzaB BHLUdx6Y+z58JWG+UA0z9ULKdrXpPTD6RlJgfnt7yUdBb1xVhGsXU2VjjjD/VWb1j1+R ddR7FQvRX08J+ibYgEP+CKyJ93YWcVtilgczOm8a/iPj/Fgix+SsxrcyU+6K1S0T/Mn4 mcybSoxS63PbUhCYsza0rf8HVHavniHH1bOlAW3rfC6APCAuKg3IVWmPRFQwggYnQuwn 0SRqevDENaq4Zs63KgiPh0pz1KZj69Xvk1v3I5Xboiktrcpb8Gy/n0wHytG2nPXTd2HG Ztfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b="rvvelZ/w"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73si1584664pfm.50.2019.02.06.20.37.10; Wed, 06 Feb 2019 20:37:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b="rvvelZ/w"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbfBGEfC (ORCPT + 99 others); Wed, 6 Feb 2019 23:35:02 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:17398 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbfBGEfC (ORCPT ); Wed, 6 Feb 2019 23:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1549514100; s=strato-dkim-0002; d=xenosoft.de; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=4RCZJtim6FzAWTAE5STy48t7VfnqZ8YM7yrGj0CnzHY=; b=rvvelZ/weJzfQemGPUZx03sYHqcavelwskB3N/ogxbPiT1XqM2CTXZnJSnOBKRoODQ IbDObc3e+lXf2obyYFRotjljikdG8iN3A5I4xOcPIPCxBVUqtkaSMwb1a8z1wi+eFnYz ayQUFkR8lbwUXeAVYwpAz9SHt+xQkHwWbrKD6tmg+rX8ktibf9Ob6Viefl9dlHHoJdgF BFXziGyT21vDcbvcx3Sn4LFi7LvEG0pwECF2gi5FKJCJRfUCUUpldQuri6FjOHINxkd7 gcrNpV1lqn3K3Y1USj069oOohyvShaHMusahF6jnJa+2wXGPqQiDfDHoZdO48QNv31ZA gCgA== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGN0rBVhd9dFr6KxrfO5Oh7R7NWZ5irpilnQb0empL4BoZuMumiBlihp1rlLmzaQ=" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a01:598:8181:7b2f:5890:9cb6:8e8:3292] by smtp.strato.de (RZmta 44.9 AUTH) with ESMTPSA id t0203dv174Yrxds (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 7 Feb 2019 05:34:53 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: use generic DMA mapping code in powerpc V4 From: Christian Zigotzky X-Mailer: iPhone Mail (16C101) In-Reply-To: <20190206151655.GA31172@lst.de> Date: Thu, 7 Feb 2019 05:34:52 +0100 Cc: Olof Johansson , linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: quoted-printable Message-Id: <61EC67B1-12EF-42B6-B69B-B59F9E4FC474@xenosoft.de> References: <96762cd2-65fc-bce5-8c5b-c03bc3baf0a1@xenosoft.de> <20190201080456.GA15456@lst.de> <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> <20190206151505.GA31065@lst.de> <20190206151655.GA31172@lst.de> To: Christoph Hellwig Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, I also didn=E2=80=99t notice the 32-bit DMA mask in your patch. I have to re= ad your patches and descriptions carefully in the future. I will test your n= ew patch at the weekend. Thanks, Christian Sent from my iPhone > On 6. Feb 2019, at 16:16, Christoph Hellwig wrote: >=20 >> On Wed, Feb 06, 2019 at 04:15:05PM +0100, Christoph Hellwig wrote: >> The last good one was 29e7e2287e196f48fe5d2a6e017617723ea979bf >> ("dma-direct: we might need GFP_DMA for 32-bit dma masks"), if I >> remember correctly. powerpc/dma: use the dma_direct mapping routines >> was the one that you said makes the pasemi ethernet stop working. >>=20 >> Can you post the dmesg from the failing runs? >=20 > But I just noticed I sent you a wrong patch - the pasemi ethernet > should set a 64-bit DMA mask, not 32-bit. Updated version below, > 32-bit would just keep the previous status quo. >=20 > commit 6c8f88045dee35933337b9ce2ea5371eee37073a > Author: Christoph Hellwig > Date: Mon Feb 4 13:38:22 2019 +0100 >=20 > pasemi WIP >=20 > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethern= et/pasemi/pasemi_mac.c > index 8a31a02c9f47..2d7d1589490a 100644 > --- a/drivers/net/ethernet/pasemi/pasemi_mac.c > +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c > @@ -1716,6 +1716,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct p= ci_device_id *ent) > err =3D -ENODEV; > goto out; > } > + dma_set_mask(&mac->dma_pdev->dev, DMA_BIT_MASK(64)); >=20 > mac->iob_pdev =3D pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa001, NULL); > if (!mac->iob_pdev) {