Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AH/aaMRFAA55f38CReIncKJ1GYnF86YWxBRYc798d?=
 =?us-ascii?q?s5kLTJ78ociwAkXT6L1XgUPTWs2DsrQY07qQ6/iocFdDyK7JiGoFfp1IWk1Nou?=
 =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?=
 =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDmwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?=
 =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?=
 =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlC?=
 =?us-ascii?q?YHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95eWCxPAIyy?=
 =?us-ascii?q?b4UBAekcM+hGs4bwvEcOoQekCAWwGO/j1j1Fi3nr1qM6yeQhFgTG0RQiENIPsX?=
 =?us-ascii?q?XUrMj1NKAPWu+2zKnH1zTDZO5R1Db96YnIcgouofCQUb5sf8fc0lQvGB/fjlmK?=
 =?us-ascii?q?t4PqIi6V2/0LvmOG7ORgTfqih3A7pwx1uDSixcchhpPUio8UyF3I7yd0zJgzKN?=
 =?us-ascii?q?alUkB0e8SkH4FVtyyCMot2Rd4tTH9wtSYhz70GpYa7fC8XyJQ73xLfa+KIc4yP?=
 =?us-ascii?q?4h/7UeaeOzZ4hHZ8dLK7iRa+7FGsyuP+W8WqylpKoS1Fkt7DtnAJyRPf8NSISv?=
 =?us-ascii?q?x4/ku52DaP0R7c6v1cLEwqiabWL4Qtz70wm5YJrEjOHy37lF/0gaOIbkkk//Kn?=
 =?us-ascii?q?6+XjYrXovJ+cMIp0hxn+M6UvmsywG+U4PhQSU2WV4um8yaHs/VfjTLpUk/I2j7?=
 =?us-ascii?q?HVsIrGKsQDuq65HwhV354n6xa+CTemzdsZkWAELF1bYhKHiZbmO1XVLfDmAvew?=
 =?us-ascii?q?nU6snC1ox//YJL3hBIvCLnzZnLfmZ7Z95B0U9A1m4dlB5p4cL7AFJP/pEhv9vc?=
 =?us-ascii?q?LVCzc1OhK5xuLgBsk70I4CDzGhGKicZZLTo1+V4aodI+CNLNsEqjb0KqB9vNbz?=
 =?us-ascii?q?hmV/lFMAK/r6laALYWy1S6w1a36SZmDh15JYST8H?=
MIME-Version: 1.0
References: <20190205221559.17545-1-yzhai003@ucr.edu> <20190206.201736.1146228626076916564.davem@davemloft.net>
 <CABvMjLQ6MYtGYeLxwceZsvcyn4oScgMo+BGQMHw7SkZ1uxFmHQ@mail.gmail.com>
In-Reply-To: <CABvMjLQ6MYtGYeLxwceZsvcyn4oScgMo+BGQMHw7SkZ1uxFmHQ@mail.gmail.com>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Wed, 6 Feb 2019 21:53:16 -0800
Message-ID: <CABvMjLTymaszPdX5afOHFfFBS1AueVzRVra5_QUr144GahH5gQ@mail.gmail.com>
Subject: Re: [PATCH] net: stmmac: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized
To:     David Miller <davem@davemloft.net>
Cc:     Chengyu Song <csong@cs.ucr.edu>, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks, but why initialization matters here? Is performance the main concern?


On Wed, Feb 6, 2019 at 9:52 PM Yizhuo Zhai <yzhai003@ucr.edu> wrote:
>
> Thanks, but why initialization matters here? Is performance the main concern?
>
> On Wed, Feb 6, 2019 at 8:17 PM David Miller <davem@davemloft.net> wrote:
>>
>> From: Yizhuo <yzhai003@ucr.edu>
>> Date: Tue,  5 Feb 2019 14:15:59 -0800
>>
>> > @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv)
>> >       struct sunxi_priv_data *gmac = priv->plat->bsp_priv;
>> >       struct device_node *node = priv->device->of_node;
>> >       int ret;
>> > -     u32 reg, val;
>> > +     u32 reg, val = 0;
>> > +
>> > +     ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val);
>> > +     if (ret) {
>> > +             dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n");
>> > +             return ret;
>> > +     }
>>
>> I agree with the other reviewer that since you check 'ret' the initialization of
>> 'val' is no longer needed.
>
>
>
> --
> Kind Regards,
>
> Yizhuo Zhai
>
> Computer Science, Graduate Student
> University of California, Riverside


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside