Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] xhci: Convert xhci_handshake() to use
 readl_poll_timeout()
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-usb@vger.kernel.org
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20190207000308.7051-1-andrew.smirnov@gmail.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <63866354-48b8-5787-39de-5c23e7471f6f@linux.intel.com>
Date:   Thu, 7 Feb 2019 10:32:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190207000308.7051-1-andrew.smirnov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07.02.2019 02:03, Andrey Smirnov wrote:
> Xhci_handshake() implements the algorithm already captured by
> readl_poll_timeout(). Convert the former to use the latter to avoid
> repetition.

readl_poll_timeout() doesn't really work here as it might sleep.

iopoll.h:

/**
  * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs
  *
...                                                                                                              
  * Returns 0 on success and -ETIMEDOUT upon a timeout. In either
  * case, the last read value at @addr is stored in @val. Must not
  * be called from atomic context if sleep_us or timeout_us are used.
  
-Mathias