Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Feb 2019 09:56:35 +0100
From:   Thierry Reding <treding@nvidia.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Timo Alho <talho@nvidia.com>, Jon Hunter <jonathanh@nvidia.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: tegra: Refactor BPMP driver
Message-ID: <20190207085634.GC8741@ulmo>
References: <20190206221711.GA21703@roeck-us.net>
MIME-Version: 1.0
In-Reply-To: <20190206221711.GA21703@roeck-us.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--KN5l+BnMqAQyZLvT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 06, 2019 at 02:17:11PM -0800, Guenter Roeck wrote:
> On Thu, Jan 24, 2019 at 07:03:53PM +0200, Timo Alho wrote:
> > Split BPMP driver into common and chip specific parts to facilitate
> > adding support for previous and future Tegra chips that are using BPMP
> > as co-processor.
> >=20
> > Signed-off-by: Timo Alho <talho@nvidia.com>
> > Acked-by: Jon Hunter <jonathanh@nvidia.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>=20
> arm:allmodconfig in linux-next:
>=20
> drivers/firmware/tegra/bpmp.o:(.rodata+0x280): undefined reference to `te=
gra210_bpmp_ops'
> drivers/firmware/tegra/bpmp.o:(.rodata+0x2ac): undefined reference to `te=
gra186_bpmp_ops'

Hi Guenter,

this should be fixed by the below patch. Running build tests now.

Thierry
--- >8 ---
diff --git a/drivers/firmware/tegra/bpmp-private.h b/drivers/firmware/tegra=
/bpmp-private.h
index 07c3d46abb87..cc343f4ebafb 100644
--- a/drivers/firmware/tegra/bpmp-private.h
+++ b/drivers/firmware/tegra/bpmp-private.h
@@ -23,7 +23,11 @@ struct tegra_bpmp_ops {
 	int (*resume)(struct tegra_bpmp *bpmp);
 };
=20
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC)
 extern const struct tegra_bpmp_ops tegra186_bpmp_ops;
+#endif
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)
 extern const struct tegra_bpmp_ops tegra210_bpmp_ops;
+#endif
=20
 #endif
diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
index 8e3f79959d48..6498c848c82c 100644
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -813,6 +813,7 @@ static int __maybe_unused tegra_bpmp_resume(struct devi=
ce *dev)
=20
 static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
=20
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC)
 static const struct tegra_bpmp_soc tegra186_soc =3D {
 	.channels =3D {
 		.cpu_tx =3D {
@@ -832,7 +833,9 @@ static const struct tegra_bpmp_soc tegra186_soc =3D {
 	.ops =3D &tegra186_bpmp_ops,
 	.num_resets =3D 193,
 };
+#endif
=20
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)
 static const struct tegra_bpmp_soc tegra210_soc =3D {
 	.channels =3D {
 		.cpu_tx =3D {
@@ -853,10 +856,15 @@ static const struct tegra_bpmp_soc tegra210_soc =3D {
 	},
 	.ops =3D &tegra210_bpmp_ops,
 };
+#endif
=20
 static const struct of_device_id tegra_bpmp_match[] =3D {
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC)
 	{ .compatible =3D "nvidia,tegra186-bpmp", .data =3D &tegra186_soc },
+#endif
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)
 	{ .compatible =3D "nvidia,tegra210-bpmp", .data =3D &tegra210_soc },
+#endif
 	{ }
 };
=20

--KN5l+BnMqAQyZLvT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxb8sIACgkQ3SOs138+
s6EDgA//V+zfQTeTEaLxmv8OuK0/W8+oaQ/gcK43P3WDbud1NLka65b8cfd+qVoF
mp71mm3FabYKPeeTEtYfkQM3IItFBQqsqTGgo9Q0MPQi2isDYvIAvWFhrRdqxuwj
IzUL4go+FSjMrTQ6mkZuoY5XzgDrs+Vi9eR70tES7dnD00GcU1ygXZpXfTT1zwCD
9EkqQ6oKe1opb3Nkr3I3u6zPzfgrImTAvVKMAn6Oum7wkesDO7YOxW3DLXnyZhyA
rpkrxxDjjric5EjCrm2Wj29/bEq4Nts00ezbCLfdaama0LVJS93wkPyZFtn2IIWE
NfzCqLPSMmU7WyTrQhptocOGTIHjuDJMHzGZqTy9Ijn7Jws0+lbJT4uK7Qb7GO9G
T1z8DAchVNIePoeyhx421tSRfMty839joW2p2lkQRcK/ASlakoatXU+KzLG8RZ8K
PIjlRtDDyIQJ69gRJ8B+Ql2t98opjKLCRayVFs2Wx3j4NrxVnkNme/jXmZMXLsEL
pD42hFL/G4mh1ArQYk03D8tu4NI0OAE9jUcN+y+eZhqr3XQ7QfbYmkk3u07cda0Q
U/3JkFVsAqIFlnU4aZOab8NaPdVlKZPVvP7l3dy+sOfDrdRA0LuG/pymmeN339U/
A2s89Li/rzGH02i1d1lTk/3qZQfW1Gcpi4sZWsdFrMK90688MNc=
=aBrE
-----END PGP SIGNATURE-----

--KN5l+BnMqAQyZLvT--