Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp141100imj; Thu, 7 Feb 2019 01:51:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IbUlVd4P8fUeqn8jna3dn4+3RLj+NL9cuAWnh3pmAaPfqsYaCNYK83UU4KSxP4v5iguWkAi X-Received: by 2002:a63:b81a:: with SMTP id p26mr14268195pge.433.1549533066725; Thu, 07 Feb 2019 01:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549533066; cv=none; d=google.com; s=arc-20160816; b=S5uzoxTKkGdOtOmNE3TLTWtHv9Zn0EPa0mQbLqgkYRf98NWGT3jpxjQM5iRLGDTFm/ c6EOubCN1+UfVcuZN05RDrEBZX5tRKEe3hkKUDbUnitONCSXNSmfUJBw/Puhni0dhE1P 37ht9GVODfj8uppUnxHTdpwF0f9WsoflB5LUu7U2e/OxGRSuxSid6gJAwKiOwPF0m6oc 3KHPp2LYaNUwAxLy2LG8WJ4e+xNmzYGR6PhB44hBqp5fOSPk319YexCqDcmEpTXuVQMC 2J5iNOUO8B/QEgKANVM7UV/5mND6IlStqRRMB7H3g79w0peLegrT32fi15WQ+Q4RvkMy 3uTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PjEjCTtaRuujc83d4ZEeDWrrUBnhFmSgRurNtsGMiJ0=; b=AstN5cu5+cWjMLPc4Ta8pJB2BWDC3O89dsTm4CljbB9y5VcymcLrcqX0cd6JzOmbTo 3ujFFsbF3/4zgGj7Lmk3Ez7+PkZtBUGSE6WYRq/BSa0vVWRmqNugd8/BG4VGS8C8Z25r oAdbGfHSqZYQ1yfHB/eHc7CI2m3rTNuMRL/ZHuMa/WrN/cVfkWPTB/dZYAoPi75Z4Z3h XbPaNoMEVkhEXjb2f2DTUvDFnMnjGIIP5BpBrtevoFDmLegFQf60xECIGgh8Y35gIxzj mBdLq3HISG1/nhzm465rDEHQBCt9BwY3+Nl7fFYwGt1a7H1HWhgtUzm88STxTVjZ3Sp/ P2pQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si8523076pls.41.2019.02.07.01.50.50; Thu, 07 Feb 2019 01:51:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727234AbfBGJu2 (ORCPT + 99 others); Thu, 7 Feb 2019 04:50:28 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:36187 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727203AbfBGJu1 (ORCPT ); Thu, 7 Feb 2019 04:50:27 -0500 Received: from mc-bl-xps13.lan (aaubervilliers-681-1-80-177.w90-88.abo.wanadoo.fr [90.88.22.177]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 2F9D8100014; Thu, 7 Feb 2019 09:50:23 +0000 (UTC) From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com Subject: [PATCH net-next v2 10/10] net: phy: marvell10g: add support for the 88x2110 PHY Date: Thu, 7 Feb 2019 10:49:39 +0100 Message-Id: <20190207094939.27369-11-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190207094939.27369-1-maxime.chevallier@bootlin.com> References: <20190207094939.27369-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds support for the 88x2110 PHY, which is similar to the already supported 88x3310 PHY without the SFP interface. It supports 10/100/1000BASET along with 2.5GBASET, 5GBASET and 10GBASET, with the same interface modes that are used by the 3310. This PHY don't have the same issue as the 88x3310 regarding 2.5/5G abilities, and correctly follows the 802.3bz standard to list the supported abilities. Signed-off-by: Maxime Chevallier Suggested-by: Antoine Tenart --- V1 -> V2: Use a #define for the PHY ID, since we also do that for the 3310. Removed the mv2110_config_init implementation since we now manually check for the PMA device id when using the quirk. drivers/net/phy/marvell10g.c | 13 +++++++++++++ include/linux/marvell_phy.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index 2593db608af7..fa4847662c81 100644 --- a/drivers/net/phy/marvell10g.c +++ b/drivers/net/phy/marvell10g.c @@ -508,12 +508,25 @@ static struct phy_driver mv3310_drivers[] = { .aneg_done = mv3310_aneg_done, .read_status = mv3310_read_status, }, + { + .phy_id = MARVELL_PHY_ID_88E2110, + .phy_id_mask = MARVELL_PHY_ID_MASK, + .name = "mv88x2110", + .features = PHY_10GBIT_FEATURES, + .probe = mv3310_probe, + .soft_reset = gen10g_no_soft_reset, + .config_init = mv3310_config_init, + .config_aneg = mv3310_config_aneg, + .aneg_done = mv3310_aneg_done, + .read_status = mv3310_read_status, + }, }; module_phy_driver(mv3310_drivers); static struct mdio_device_id __maybe_unused mv3310_tbl[] = { { MARVELL_PHY_ID_88X3310, MARVELL_PHY_ID_MASK }, + { MARVELL_PHY_ID_88E2110, MARVELL_PHY_ID_MASK }, { }, }; MODULE_DEVICE_TABLE(mdio, mv3310_tbl); diff --git a/include/linux/marvell_phy.h b/include/linux/marvell_phy.h index 5851d68d828a..8596a861940e 100644 --- a/include/linux/marvell_phy.h +++ b/include/linux/marvell_phy.h @@ -21,6 +21,7 @@ #define MARVELL_PHY_ID_88E1545 0x01410ea0 #define MARVELL_PHY_ID_88E3016 0x01410e60 #define MARVELL_PHY_ID_88X3310 0x002b09aa +#define MARVELL_PHY_ID_88E2110 0x002b09b8 /* The MV88e6390 Ethernet switch contains embedded PHYs. These PHYs do * not have a model ID. So the switch driver traps reads to the ID2 -- 2.19.2