Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp245266imj; Thu, 7 Feb 2019 03:44:04 -0800 (PST) X-Google-Smtp-Source: AHgI3IaV8yGZaSt7FjrlzvDRXBQuamzqlLYiyu9KVDKLg8scbdik1xtAZ4Vgf77F6ltVQqF7zABr X-Received: by 2002:a17:902:be11:: with SMTP id r17mr16126115pls.308.1549539844751; Thu, 07 Feb 2019 03:44:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549539844; cv=none; d=google.com; s=arc-20160816; b=GXsqm43lDJ7Dr85uiQ5C1B5PBrInp9QvQyH/CdV8HL3Fa1jWKMFn07nD4AbA3U+nj/ WqPnVwVJwFvaj9us8P1fN0QCDT68PoqUkW4zfBdGA5sO5QVUb/7iAyrx4nVkxq0FKp4A IlCl43jpTQbpFIPsDpTnQuqWfBKTz7fjlcw7ldxzWkkAGcRp5Oz6+sdW9cPIdK6jvkil Sun5mvHMevcdiLpYPucnnmfCPmyVbWJ/s3+CDeQ8SiuFMxPFtVNDK2yWrpiqTAijUD+P Fwt1VoZBC1cDj7CUyHi+b65CnLISCLIJG/nrgi7V+4tUNsLBvWqPGBjGOpgsTg56gZB0 b6rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UluL5r1vocn79Z0AIka1wIWKPKxT4FAOqKSIAzYVOsU=; b=B1fUtHrtAqym9jYo2NyFnY0B+H+QawDALtL6SQV7gNfXja39lyb6Sc5k4D7qnZnuhs I2rnEx0+NxBCfLJBK6bR+sgCtNItleunTRSG/w7bXcggmTR8Zs0KrFcPREtjNT80SMMS MRnJhmlwXPDTK6hs449o6MJFVWJRwQSCeIwBOTE5EiNVp5mqYEWxLwATEY0fbRjVD3Ai 3fdPVv03x3aU9oL425tw6iEsGnYsLeMktuWL1niuoW+ZlQsverkb0S8dcA+aKDRgZfXj +068IET7PWLBYYxiwFLLrmGPaLnpbMq4AnmeikixuTSwqGSGOTpOFXksb7Omv74ScF9Y esmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ruVF58JU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 98si1233387pla.320.2019.02.07.03.43.49; Thu, 07 Feb 2019 03:44:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ruVF58JU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727346AbfBGLnL (ORCPT + 99 others); Thu, 7 Feb 2019 06:43:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:33272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfBGLnH (ORCPT ); Thu, 7 Feb 2019 06:43:07 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6FEC21908; Thu, 7 Feb 2019 11:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549539787; bh=mNeiq/qtNnprxDUJgsLHL5Yxqcrx/who+m3AEOR6Ico=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ruVF58JUqunzin0WaSA1ZEB4MxxzKEtzK//huKwzHNSXTjoGc6Ya81JcqiMWwkCoD I6pDLlFvBc1rNyMYPyySaUXpgUvjNgkkgzXPA6ZIFatshWnczRP5wcRgRLQUR59Re+ 8P6Vyk10Rt6+E4nMkbyfa9y4yPhwHu2rcqNyoDLo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Peter Oskolkov , Florian Westphal , "David S. Miller" , Mao Wenan , Ben Hutchings Subject: [PATCH 4.4 23/34] net: modify skb_rbtree_purge to return the truesize of all purged skbs. Date: Thu, 7 Feb 2019 12:42:05 +0100 Message-Id: <20190207113026.469442952@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190207113025.552605181@linuxfoundation.org> References: <20190207113025.552605181@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Oskolkov commit 385114dec8a49b5e5945e77ba7de6356106713f4 upstream. Tested: see the next patch is the series. Suggested-by: Eric Dumazet Signed-off-by: Peter Oskolkov Signed-off-by: Eric Dumazet Cc: Florian Westphal Signed-off-by: David S. Miller Signed-off-by: Mao Wenan Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- include/linux/skbuff.h | 2 +- net/core/skbuff.c | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2278,7 +2278,7 @@ static inline void __skb_queue_purge(str kfree_skb(skb); } -void skb_rbtree_purge(struct rb_root *root); +unsigned int skb_rbtree_purge(struct rb_root *root); void *netdev_alloc_frag(unsigned int fragsz); --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -2380,23 +2380,27 @@ EXPORT_SYMBOL(skb_queue_purge); /** * skb_rbtree_purge - empty a skb rbtree * @root: root of the rbtree to empty + * Return value: the sum of truesizes of all purged skbs. * * Delete all buffers on an &sk_buff rbtree. Each buffer is removed from * the list and one reference dropped. This function does not take * any lock. Synchronization should be handled by the caller (e.g., TCP * out-of-order queue is protected by the socket lock). */ -void skb_rbtree_purge(struct rb_root *root) +unsigned int skb_rbtree_purge(struct rb_root *root) { struct rb_node *p = rb_first(root); + unsigned int sum = 0; while (p) { struct sk_buff *skb = rb_entry(p, struct sk_buff, rbnode); p = rb_next(p); rb_erase(&skb->rbnode, root); + sum += skb->truesize; kfree_skb(skb); } + return sum; } /**