Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] xhci: Use ffs() to find page size in xhci_mem_init()
To:     Felipe Balbi <felipe.balbi@linux.intel.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-usb@vger.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20190207000349.7816-1-andrew.smirnov@gmail.com>
 <1ecb0604-3e27-810e-9fae-18d9d1bf7ff9@linux.intel.com>
 <87mun8klxj.fsf@linux.intel.com>
 <74208350-eba5-c299-376e-9df194fe71b5@intel.com>
 <87k1iblval.fsf@linux.intel.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <900f399d-cd97-eef8-56ba-ba06293a1a84@linux.intel.com>
Date:   Thu, 7 Feb 2019 13:54:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <87k1iblval.fsf@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07.02.2019 12:58, Felipe Balbi wrote:
> 
> Hi,
> 
> Mathias Nyman <mathias.nyman@intel.com> writes:
>>>>> Get page size order using ffs() instead of open coding it with a loop.
>>>>>
>>>>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>>>>> Cc: Mathias Nyman <mathias.nyman@intel.com>
>>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>>> Cc: linux-usb@vger.kernel.org
>>>>> Cc: linux-kernel@vger.kernel.org
>>>>> ---
>>>>>     drivers/usb/host/xhci-mem.c | 6 +-----
>>>>>     1 file changed, 1 insertion(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
>>>>> index 36a3eb8849f1..44b43c3d819f 100644
>>>>> --- a/drivers/usb/host/xhci-mem.c
>>>>> +++ b/drivers/usb/host/xhci-mem.c
>>>>> @@ -2362,11 +2362,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
>>>>>     	page_size = readl(&xhci->op_regs->page_size);
>>>>>     	xhci_dbg_trace(xhci, trace_xhci_dbg_init,
>>>>>     			"Supported page size register = 0x%x", page_size);
>>>>> -	for (i = 0; i < 16; i++) {
>>>>> -		if ((0x1 & page_size) != 0)
>>>>> -			break;
>>>>> -		page_size = page_size >> 1;
>>>>> -	}
>>>>> +	i = ffs(page_size);
>>>>>     	if (i < 16)
>>>>>     		xhci_dbg_trace(xhci, trace_xhci_dbg_init,
>>>>>     			"Supported page size of %iK", (1 << (i+12)) / 1024);
>>>>
>>>> Hi
>>>>
>>>> using ffs() is a welcome change, but it will give different a result than the loop.
>>>>
>>>> *old loop
>>>>      valid page_size value if i < 16
>>>> *ffs()
>>>>      valid page_size value if i >= 1 and i < 17
>>>
>>> off-by-one, just use i = ffs() - 1. Or use __ffs().
>>
>> and handle the page_size == 0 case.
> 
> Can it be zero in real life, or are you protecting against academic
> possibility that's never going to happen in HW?
> 

whole page_size check is not really doing much, just printing out
different debug messages.

-Mathias