Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp384778imj; Thu, 7 Feb 2019 05:56:45 -0800 (PST) X-Google-Smtp-Source: AHgI3IY/i21Ay1J1nLBLQ1jQbl0xh1MppvbZFUh95ARenwFbB+3Jg44FY/be3EE2IoAQGZ0wTA2i X-Received: by 2002:a62:a510:: with SMTP id v16mr16247049pfm.18.1549547805012; Thu, 07 Feb 2019 05:56:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549547805; cv=none; d=google.com; s=arc-20160816; b=lxjPAWWFKiUaipQZuNjjECM1jmEib805YX87n+zvMRpmKTB1IXoBAFjgqRyDYa5GIT ByNC2WsvzBhBCLxcS8CEezUVV4k4iuEpMt/0RoTQTFv7Uh/qYkCXWj/b46QNckdiOIOx zMZf75/zip2IPJjqxMnTq867uDRKW0gsHTlOhwnWoJ4Ng2+tFwijVk/dc8PDeyuUYrwA Wdbjk4VYrq0MIeaBANPaS1pe44wdNAGLON0enKUsYTJq9ixeGRPrVEekOn8JFESRAsVB E25cqgKkdIxmBlXx7MfXItdIzvDL4jkEBbLeMR2LCuTdNup0aMPW3ho/v7GvYkIY2DMq 5ClQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MslmhBf6sHBX+lTIZiGv5oF8ktq/q6NsQm5zdWGHpTQ=; b=0PmsNVTmM2kAXaODRpYHFToiv8MVccFCbXyJHVrZvsal7G3BIUJ0H6sKEme/YdihRm sZ5j/Eg9chga1fRIRqJ5saTH0TcKzUWoYF140fm2JqFEy8C6O6YgpNTX4DTABx3w9UsV UF8UbHpPLgZl4Oy494zt0ndmXgk1FU62ilIYM+Rwkh4KNEaji4u2kxmM45nZf/y2Xm70 5S2MVkGIwz93OE1GLjpeSfajBzX6bIIYXNFnkF43xL1/dhMY2iiVrU5miRvYIurPSP1u 6UaOFz6zeqgd0hV/KYGyH9ye5ID0QDFOhEu55zi4izgsiyVMKRzdPVdaa1Tjvd7BHQ+G ZXWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dTixeQLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z61si9412699plb.49.2019.02.07.05.56.29; Thu, 07 Feb 2019 05:56:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dTixeQLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbfBGNye (ORCPT + 99 others); Thu, 7 Feb 2019 08:54:34 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:33664 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfBGNye (ORCPT ); Thu, 7 Feb 2019 08:54:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MslmhBf6sHBX+lTIZiGv5oF8ktq/q6NsQm5zdWGHpTQ=; b=dTixeQLVu7KVSglvTuT6y6NrB rYgagcrHhJjihyiiIkRYAiB55rstLOlgOmT/ytB6+MR4UHv2vN/3TX71ojKEKepM8SM2PM6G+vVRM SSi1Bqwl0MYMHTVCwd25Tkg7CkQwvFOQ1e5S8dLp8+Mo2W2npAnkDWxmP00Jx0CmqZmL7ayCGsO5k bopYRxg/SUtKwzZ3xaha6RLVrjXS93Tq3k7TytGPy6iLX1acucpccOyvne5HPEFRbNf5FPihb2+bX W4dPTweVdsHFZUub8DYpjK75j3A37u79TwYV91pIW4rBFkGuleAtWDlckD64Rgal0bkx4q9IA739A 2OqF0klUA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1grk7n-0003OL-U6; Thu, 07 Feb 2019 13:53:55 +0000 Date: Thu, 7 Feb 2019 05:53:55 -0800 From: Matthew Wilcox To: Christophe Leroy Cc: Kees Cook , Andrew Morton , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Mike Rapoport , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/2] mm: add probe_user_read() Message-ID: <20190207135355.GU21860@bombadil.infradead.org> References: <39fb6c5a191025378676492e140dc012915ecaeb.1547652372.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39fb6c5a191025378676492e140dc012915ecaeb.1547652372.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 04:59:27PM +0000, Christophe Leroy wrote: > v3: Moved 'Returns:" comment after description. > Explained in the commit log why the function is defined static inline > > v2: Added "Returns:" comment and removed probe_user_address() The correct spelling is 'Return:', not 'Returns:': Return values ~~~~~~~~~~~~ The return value, if any, should be described in a dedicated section named ``Return``.