Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Feb 2019 17:08:02 +0100
From:   Thierry Reding <treding@nvidia.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: Add Tegra Combined UART driver
Message-ID: <20190207160801.GA6991@ulmo>
References: <20190207143916.GA11121@roeck-us.net>
MIME-Version: 1.0
In-Reply-To: <20190207143916.GA11121@roeck-us.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 07, 2019 at 06:39:16AM -0800, Guenter Roeck wrote:
> On Wed, Jan 23, 2019 at 11:28:19AM +0100, Thierry Reding wrote:
> > The Tegra Combined UART (TCU) is a mailbox-based mechanism that allows
> > multiplexing multiple "virtual UARTs" into a single hardware serial
> > port. The TCU is the primary serial port on Tegra194 devices.
> >=20
> > Add a TCU driver utilizing the mailbox framework, as the used mailboxes
> > are part of Tegra HSP blocks that are already controlled by the Tegra
> > HSP mailbox driver.
> >=20
> > Based on work by  Mikko Perttunen <mperttunen@nvidia.com>.
> >=20
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>=20
> In case 0day hasn't reported it:
>=20
> arm64:allmodconfig:
>=20
> ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined!
>=20
> mbox_flush() isn't exported.

We only ever test TCU as built-in because it's used for the system
console, so I never actually tested this as a module. I sent a fix
for this earlier this week:

	https://lore.kernel.org/patchwork/patch/1038464/

Thanks,
Thierry

--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxcV+EACgkQ3SOs138+
s6F2hhAAkE8/2g42itbQfle0OjIYXCHozySLdAF9vs4Q9tzrTUMtglKQ2oElyHT6
qHJGNiu1sv/m8TMMOmLZ6GC50JzaSglidx/VJUxNx1TZrrfp6kpW2bWE5p4Av7Mg
g68PERX3zbpCEcdfGCMqP182lmhsVke1PzLOP0aVCG46+0j6p64a2jQqRaHZq0j9
ZQ8GR4otV3xThEIQ4pDpkjNhDCwlWW84ysCxPl/p/ifpnZQHien5I0U3RmuYACI3
bpjAbS9B+bZrL5pjxSIC6cBqRCiLslod86rO3VD56BwRJs9mf+O2f6DpaKYTrhH3
+oISLh4P7T+n0jdAtetS1O7sHmccA6/ofe3E/dBHvtc/e0GVwQYYRd6Phf/Dsrlt
m3X5cW8K8RZy57hWgwgBMHR+c4H7QfhB90Ow2bCNUV/FU/a7/lX9VnqVeINvRh59
wXYIPqbl3xYnykqM4lfmVt2Fd6OIzQj0cXvXYcVuKeZICH6cW4ijPjMxLheasEil
0icIx9/K7Pisic4ste7fxqDfGeW0P/64Q0PdRFIKas+f3yb/jLd8r0VjS7PXutfV
HIRCnguJGO8qpAaAYLlSl8h1UMxF8lVDnEkoMvXaSMgwkKWpHb7oljGlysk3TFsd
wWDMjVxTlX3nRVeR3e08PoCCWkp01Snr9XXXUwQ+RMkpwM3nZNo=
=kZsL
-----END PGP SIGNATURE-----

--M9NhX3UHpAaciwkO--