Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AY+4IvBGSFPV1G5FXSqdnAp1GYnF86YWxBRYc798d?=
 =?us-ascii?q?s5kLTJ7zpsuwAkXT6L1XgUPTWs2DsrQY07qQ6/iocFdDyK7JiGoFfp1IWk1Nou?=
 =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?=
 =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDmwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?=
 =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?=
 =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlC?=
 =?us-ascii?q?YHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95eWCxPAIyy?=
 =?us-ascii?q?b4UBAekcM+hGs4bwvEcOoQekCAWwGO/j1j1Fi3nr1qM6yeQhFgTG0RQiENIPsX?=
 =?us-ascii?q?XUrMj1NKAPWu+2zKnH1zTDZO5R1Db96YnIcgouofCQUb5sf8fc0lQvGB/fjlmK?=
 =?us-ascii?q?t4PqIi6V2/0LvmOG4eRgUuevhHQmqwF3ujWg3cAsio7VhoIRy1DE8z91z5oyJd?=
 =?us-ascii?q?29TkNwfN2qEINIui2EK4d7RtkuTmJotSog1LEKpZ22cDIUxJg72xLSbeGMfZKS?=
 =?us-ascii?q?7RL5TumRJC91hHdieL2imRm/6VOgyujgVsms11ZKszZFnsHMtn8T0xzT7dCKSv?=
 =?us-ascii?q?5n8Ueg3TaDzgTT6uNZLUwtm6rXNYItzqIqmpoctkTDGSD2mEHog6OMakok/e2o?=
 =?us-ascii?q?5/zmYrXguJCcK5d5hh/iPqkqgMCyAuQ1PhIQU2SH+umwzqPv8VHlTLlSi/05iK?=
 =?us-ascii?q?jZsJTUJcQBoa65BhdY04Yi6ha/FTim0cgUkWUJIV9eZRKIk5LpN0vQL//lEPez?=
 =?us-ascii?q?m06snytzx/DaIr3hBY3ALnzCkLfnYLZ85FdQyAktwtBF4ZJbFLUBLentWk/+qt?=
 =?us-ascii?q?PYFAU1Mw+qzOb9DtVyyIceVXiIAq+DP6OB+WOPs8cmM+iJaccvuS70MfRts/vn?=
 =?us-ascii?q?nX48lBkHfLGgx5c/Yne/AvBnJQOSZn+60fkbFmJfjwssTPHtwG+CWD8bM2egX6?=
 =?us-ascii?q?s9vmlgIJ+tF8HOSp370+/J5zuyApADPjMOMVuLC3q9MtzcA/o=3D?=
MIME-Version: 1.0
References: <20190205221559.17545-1-yzhai003@ucr.edu> <20190206.201736.1146228626076916564.davem@davemloft.net>
 <CABvMjLQ6MYtGYeLxwceZsvcyn4oScgMo+BGQMHw7SkZ1uxFmHQ@mail.gmail.com>
 <CABvMjLTymaszPdX5afOHFfFBS1AueVzRVra5_QUr144GahH5gQ@mail.gmail.com> <20190207092454.xq5jvnfnuhcp37nm@flea>
In-Reply-To: <20190207092454.xq5jvnfnuhcp37nm@flea>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Thu, 7 Feb 2019 09:48:41 -0800
Message-ID: <CABvMjLS2ftUgxeKNxQW2npxKRjM3_=U7qg7oYTw6VrkUWcOocw@mail.gmail.com>
Subject: Re: [PATCH] net: stmmac: Variable "val" in function
 sun8i_dwmac_set_syscon() could be uninitialized
To:     Maxime Ripard <maxime.ripard@bootlin.com>
Cc:     David Miller <davem@davemloft.net>,
        Chengyu Song <csong@cs.ucr.edu>,
        Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Chen-Yu Tsai <wens@csie.org>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Make sense, I will send the new patch. Thanks for the opinion.

On Thu, Feb 7, 2019 at 1:25 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Wed, Feb 06, 2019 at 09:53:16PM -0800, Yizhuo Zhai wrote:
> >
> >
> > On Wed, Feb 6, 2019 at 9:52 PM Yizhuo Zhai <yzhai003@ucr.edu> wrote:
> > >
> > > Thanks, but why initialization matters here? Is performance the main concern?
> > >
> > > On Wed, Feb 6, 2019 at 8:17 PM David Miller <davem@davemloft.net> wrote:
> > >>
> > >> From: Yizhuo <yzhai003@ucr.edu>
> > >> Date: Tue,  5 Feb 2019 14:15:59 -0800
> > >>
> > >> > @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv)
> > >> >       struct sunxi_priv_data *gmac = priv->plat->bsp_priv;
> > >> >       struct device_node *node = priv->device->of_node;
> > >> >       int ret;
> > >> > -     u32 reg, val;
> > >> > +     u32 reg, val = 0;
> > >> > +
> > >> > +     ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val);
> > >> > +     if (ret) {
> > >> > +             dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n");
> > >> > +             return ret;
> > >> > +     }
> > >>
> > >> I agree with the other reviewer that since you check 'ret' the initialization of
> > >> 'val' is no longer needed.
> >
> > Thanks, but why initialization matters here? Is performance the main
> > concern?
>
> Not really, but if we turn this the other way around, why should we do
> something that doesn't bring anything?
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside