Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190207000308.7051-1-andrew.smirnov@gmail.com> <63866354-48b8-5787-39de-5c23e7471f6f@linux.intel.com>
In-Reply-To: <63866354-48b8-5787-39de-5c23e7471f6f@linux.intel.com>
From:   Andrey Smirnov <andrew.smirnov@gmail.com>
Date:   Thu, 7 Feb 2019 13:03:51 -0800
Message-ID: <CAHQ1cqGUohhev5+gFUMn3-6wK0zd5zkefr-RvMjtgWBaE1tunQ@mail.gmail.com>
Subject: Re: [PATCH] xhci: Convert xhci_handshake() to use readl_poll_timeout()
To:     Mathias Nyman <mathias.nyman@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 7, 2019 at 12:27 AM Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
>
> On 07.02.2019 02:03, Andrey Smirnov wrote:
> > Xhci_handshake() implements the algorithm already captured by
> > readl_poll_timeout(). Convert the former to use the latter to avoid
> > repetition.
>
> readl_poll_timeout() doesn't really work here as it might sleep.
>
> iopoll.h:
>
> /**
>   * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs
>   *
> ...
>   * Returns 0 on success and -ETIMEDOUT upon a timeout. In either
>   * case, the last read value at @addr is stored in @val. Must not
>   * be called from atomic context if sleep_us or timeout_us are used.
>
> -Mathias

Shoot, missed this part. Will change to  readl_poll_timeout_atomic() in v2.

Thanks,
Andrey Smirnov