Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190207000349.7816-1-andrew.smirnov@gmail.com> <1ecb0604-3e27-810e-9fae-18d9d1bf7ff9@linux.intel.com>
In-Reply-To: <1ecb0604-3e27-810e-9fae-18d9d1bf7ff9@linux.intel.com>
From:   Andrey Smirnov <andrew.smirnov@gmail.com>
Date:   Thu, 7 Feb 2019 13:06:36 -0800
Message-ID: <CAHQ1cqE-GeW_03edN4u_-RsZ9bm2_S07foY3obYreHp-Efpbdg@mail.gmail.com>
Subject: Re: [PATCH] xhci: Use ffs() to find page size in xhci_mem_init()
To:     Mathias Nyman <mathias.nyman@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 7, 2019 at 1:00 AM Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
>
> On 07.02.2019 02:03, Andrey Smirnov wrote:
> > Get page size order using ffs() instead of open coding it with a loop.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Mathias Nyman <mathias.nyman@intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >   drivers/usb/host/xhci-mem.c | 6 +-----
> >   1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> > index 36a3eb8849f1..44b43c3d819f 100644
> > --- a/drivers/usb/host/xhci-mem.c
> > +++ b/drivers/usb/host/xhci-mem.c
> > @@ -2362,11 +2362,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
> >       page_size = readl(&xhci->op_regs->page_size);
> >       xhci_dbg_trace(xhci, trace_xhci_dbg_init,
> >                       "Supported page size register = 0x%x", page_size);
> > -     for (i = 0; i < 16; i++) {
> > -             if ((0x1 & page_size) != 0)
> > -                     break;
> > -             page_size = page_size >> 1;
> > -     }
> > +     i = ffs(page_size);
> >       if (i < 16)
> >               xhci_dbg_trace(xhci, trace_xhci_dbg_init,
> >                       "Supported page size of %iK", (1 << (i+12)) / 1024);
>
> Hi
>
> using ffs() is a welcome change, but it will give different a result than the loop.
>
> *old loop
>    valid page_size value if i < 16
> *ffs()
>    valid page_size value if i >= 1 and i < 17
>

My bad, sorry about that, was using __fls() in the version I tested,
but then switched it to ffs() at the last minute and forgot to double
check. Will update in v2.

Thanks,
Andrey Smirnov