Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Feb 2019 23:20:28 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Dinh Nguyen <dinguyen@kernel.org>
Cc:     Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock
 support
Message-ID: <20190207232028.26b4a7f5@xps13>
In-Reply-To: <ea245b53-59c9-0d7f-f33a-44aa93db99ac@kernel.org>
References: <1547539894-12898-1-git-send-email-yamada.masahiro@socionext.com>
        <20190115092229.59e09c2d@xps13>
        <CAK7LNATnfTQXHrXJQp7732-e7hvd8ORcYubyDmz0KHaRXRMDqQ@mail.gmail.com>
        <20190128112007.440046e6@xps13>
        <da2ea926-30e9-c7b9-8b1f-ee65ccc0fb7a@kernel.org>
        <20190131182644.366a54a5@bbrezillon>
        <20190205141853.4b7ed954@xps13>
        <ea245b53-59c9-0d7f-f33a-44aa93db99ac@kernel.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dinh,

Dinh Nguyen <dinguyen@kernel.org> wrote on Thu, 7 Feb 2019 12:17:50
-0600:

> On 2/5/19 7:18 AM, Miquel Raynal wrote:
> > Hi Dinh,
> > 
> > Boris Brezillon <bbrezillon@kernel.org> wrote on Thu, 31 Jan 2019
> > 18:26:44 +0100:
> >   
> >> Hi Dinh,
> >>
> >> On Thu, 31 Jan 2019 11:24:16 -0600
> >> Dinh Nguyen <dinguyen@kernel.org> wrote:
> >>  
> >>> On 1/28/19 4:20 AM, Miquel Raynal wrote:    
> >>>> Hi Dinh,
> >>>>
> >>>> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Wed, 16 Jan
> >>>> 2019 10:27:11 +0900:
> >>>>       
> >>>>> (+CC Dinh Nguyen)
> >>>>>
> >>>>> On Tue, Jan 15, 2019 at 5:22 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:      
> >>>>>>
> >>>>>> Hi Masahiro,
> >>>>>>
> >>>>>> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Tue, 15 Jan
> >>>>>> 2019 17:11:34 +0900:
> >>>>>>        
> >>>>>>> Commit 6f1fe97bec34 ("mtd: rawnand: denali_dt: add more clocks based
> >>>>>>> on IP datasheet") introduced a more correct binding that requires
> >>>>>>> three named clocks.
> >>>>>>>
> >>>>>>> Now that all upstream DT files migrated over to it, remove the single
> >>>>>>> anonymous clock support.        
> >>>>>>
> >>>>>> I would love to do that but I think this is against the "DT backward
> >>>>>> compatibility rule".        
> >>>>>
> >>>>> Yeah, I know this rule, but we break DT binding from time to time.
> >>>>>
> >>>>>
> >>>>>      
> >>>>>> Anyway, IIRC it is accepted that this kind of
> >>>>>> rule might be broken if decided per the arch-maintainer (in this
> >>>>>> case, you I suppose). So if this is really what you want, I'll queue
> >>>>>> it.        
> >>>>>
> >>>>> My platform is fine, but this driver is used by SOCFPGA boards as well.
> >>>>>
> >>>>> I CCed the SOCFPGA maintainer, Dinh Nguyen.
> >>>>>      
> >>>>
> >>>> Gentle ping on this topic.
> >>>>       
> >>>
> >>> This patch looks fine to be. Feel free to add:
> >>>
> >>> Tested-by: Dinh Nguyen <dinguyen@kernel.org>    
> >>
> >> I think Miquel is waiting for an Acked-by to confirm that you're okay
> >> breaking backward compat with old DT.  
> > 
> > Yes, I am waiting for your Acked-by.
> > 
> >   
> 
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
> 
> Dinh

Applied to nand/next.


Thanks,
Miquèl