Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp938355imj; Thu, 7 Feb 2019 14:28:04 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia6bWvKXo9zMWh7zNcMVpM+D7q1ysxLVPw1wLpP3hwA2tPGMBY6MvKEqb23E/3y4ylrQNBm X-Received: by 2002:a63:295:: with SMTP id 143mr1795147pgc.362.1549578484694; Thu, 07 Feb 2019 14:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549578484; cv=none; d=google.com; s=arc-20160816; b=UuiYGhtvddTuW9k207J+99G1G0Kx7IA0ue9O4sTR07RSoMva/nPiog27zMCG5h0mm5 roq3Vfsnfv2/xpGq/QrKoWrwLz2bONe51IIhn6JopE+om8PgrWQ0kmrCkJlPcGnjx48v z5cFaemnnXj2gaioGMQgMt5/7ARxKoWycwq7ILrHDJjRIMRGmXiHiptynCI6uHduDEP8 FjXwimm08mSajGS7QwHIcZ2OYCVhKCL05Unbt9UrOQeFMpPOYiguIHzRHwBy0pNx8k3j sMaXLs4yUqZLSGLk8tg4rVfY9iMoKCsc6H4dHtUzpOAPjsivnJYk2u40h/748pXUVkbN bAQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=n6VV0m7OwM6sm/r2va4gnhX/8E+YVxIUEmNTwqMvQcw=; b=JA9NzZcDWZrdi60zPI5GjUUeN/ZZQ+oiramX/yNhsiw68mCDnmRo5HRTmeNerHGk6Q ZNEO+vWfQeldShRJEEDA9/twwm6+1UKLQdOwmhQZi7VJKAGENWaYXmlA8pvlKHYlQw18 H3TNKlW7WieL3QPRr53spMUBS80gmc3O720t13JeRvr0lx9MtkFw8To/HyWjc4150zen TCOSeG2gjwOtuJ5sedOtQwfNLujiFMTSwCbQqhwMPXR2nZ5Ce0Htg1NYx0cz5+9rM3M7 B2zLAK+a8LiDPJGbjZnotZjLAe3AvshjXc1zybIsWpZTAFsOBG8/sOz9cNjIft+WI3AX 4loA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JKuLesrt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si189587pgv.190.2019.02.07.14.27.49; Thu, 07 Feb 2019 14:28:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JKuLesrt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726978AbfBGW1j (ORCPT + 99 others); Thu, 7 Feb 2019 17:27:39 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]:45867 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfBGW1j (ORCPT ); Thu, 7 Feb 2019 17:27:39 -0500 Received: by mail-ot1-f51.google.com with SMTP id 32so2619536ota.12 for ; Thu, 07 Feb 2019 14:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n6VV0m7OwM6sm/r2va4gnhX/8E+YVxIUEmNTwqMvQcw=; b=JKuLesrtoPy2Mv20tKiBOiLD5OdmwJbTwT6HQB3h8zlmWwFnI34n+sXCvZGP6uSJ9D 5ciZuC8cyNNJNBowxzRFi3LMTZ+xDWQpFWhoJ91qT9ljyVz1lXNLgq83JbTW2odMg8/T H8hHWlWnQNc0Hotgnh0lHOgrrpmyQ1DKPQbeDe3DR9IhxpKu+6d00g73uRE9+LPY3QzC emywjoAOiAD451+yHFVhudbPRFfVJiwYLBdxk58GrYAlQCPzcLoMYcAFqyEP7VbrWuYG MrxFZXrdQuZhiTHJQdv1JrMV7X5oHlgyC6NXwgeyDbBfHfcTRBKZbhbbVX7Ca1lbMvih zHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n6VV0m7OwM6sm/r2va4gnhX/8E+YVxIUEmNTwqMvQcw=; b=CfnGCTOJGgyfwTz1HXg2eNwIKRQe34bQK3XaIEcU8fxMK5oE98yL2L85kSftedho4W xxliL6Nw4+hja+kYMPjA83w1GNnil9MIYU2qCBqaVNA1EgWWuBNc46wNZS5REu8VT9Qp EtWQH9NpdBTXHUr2PbFLKIunwz75/Hq2vE4x50TkJGYGDomwAE4UUTSYhtcbV9hOphb7 NXVCkojNDHiZQHk7EqV8lXF7zlBS7GcGrV1PyggZDW/Ri5R8EVwOR+KrOvcEdYLsExxy NmToHP00cw7mZMC5QC3iBLCgOUF8UR9k+ZSGkSrjBMLr236OESL9HeY6LgYYLfhYZTh/ Okgw== X-Gm-Message-State: AHQUAuZbOqgmBoL4PmFdHwSN8ISpxnCwaRyMNODsrZbA+l5KdHAB68MW W5U1yoVGFbyesoOowasYef0uSrmYgqCUcnVQ9Y4= X-Received: by 2002:a9d:7e87:: with SMTP id m7mr10815574otp.225.1549578458456; Thu, 07 Feb 2019 14:27:38 -0800 (PST) MIME-Version: 1.0 References: <20190204220952.30761-1-TheSven73@googlemail.com> In-Reply-To: From: Sven Van Asbroeck Date: Thu, 7 Feb 2019 17:27:27 -0500 Message-ID: Subject: Re: [RFC v1 0/3] Address potential user-after-free on module unload To: Dmitry Torokhov Cc: Kees Cook , Tejun Heo , Lai Jiangshan , LKML , Sebastian Reichel , Greg KH Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 7, 2019 at 5:21 PM Dmitry Torokhov wrote: > > > ./drivers//input/keyboard/matrix_keypad.c:512:1-18: missing clean-up > > of INIT_WORK/INIT_DELAYED_WORK initialized here > > This is not as simple. [...] > So in effect we do not actually leak work > past driver remove(). That's expected. No Coccinelle script is perfect (especially not my feeble attempts!) so there will be false positives.