Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alistair Francis <Alistair.Francis@wdc.com>
To:     "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
CC:     "palmer@sifive.com" <palmer@sifive.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alistair23@gmail.com" <alistair23@gmail.com>,
        Alistair Francis <Alistair.Francis@wdc.com>
Subject: [PATCH] riscv: Partially revert "Remove stat64 family from default
 syscall set"
Thread-Topic: [PATCH] riscv: Partially revert "Remove stat64 family from
 default syscall set"
Thread-Index: AQHUvzhJp5Lyoz3DO0iX2Eth67GLnQ==
Date:   Thu, 7 Feb 2019 22:55:57 +0000
Message-ID: <20190207225531.19219-1-alistair.francis@wdc.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [199.255.44.250]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;MWHPR04MB0480;6:Q1HSTVGbvySoqbrxQrSJ5f6F1/yGZ9UwjHkK9ID4KHTM/5E3/m4p83KquZ5aCXiPTL2FxtCx/IMLg1lj+DTgxmfYKWdcgE91sfah1bmiuJQdQs2aXiqqGJrwT+dxjJYQMB+yjquvBghQVCexEHFrYhhCvvkrv10qq7ukh1ypuNPdwb1ppOwyTeQWKkp+QXoDg91OdUOwMfdXFjvQUFC03FcSzF54hgpGTs2cHITCxe+XFcnraAzq9odpXFCmBRKb0ioxTKoShQYQI/naFXGRjQLeEfuo6aoL/QLL/nm4HkZLuSNB9TygO4L3lqjj1C7vof5vwCvQbR0v/f7xSVbG/mRlAnxBgPV59KBpvAlNPCWKE+YgIe0rk8bVzq1K9ZftBZtr+X4N1I4VFfW5aMVw6ZBLztf1OSeD55fh92/qdUyH6J3yphOcVXZlndKZrRx1BbD/3nPEGB3F8ENRRzkvIg==;5:JTEUj90M44dfMIudOrDzyfFGTVvO72EW7HozWHFgZ/CUSe4d+m5uk916NeHfIb48eFvFGueO3qz+MFR+lJHYVrNN0DhSlRp5c/yov1W+wPIrELZEuz0Yjf2grrhbscYR0srAbFw5jU2p4jbL0Id1XTYdDShgnGQoCawjSEMKaIQh2S/R9uebwip8U3U86BTvbKyR4nmjd1hQ2Xg+zonGzg==;7:rqT747W1Bdgxfh8NAntFZj8q+aR+RMDOQyD7LXKnFv5BoDkto5kJmgfBCAIcoCmY3aOD7QCZ+E+ufmpkmuUYspzpAnjqzUH/pBTWFQMyLf/ypgHMdnk97FE5al0gre59MqaM2yJ2UEOhD1SrjTO4wg==
x-ms-office365-filtering-correlation-id: 0d518c8e-6c99-4663-3d1d-08d68d4f6c08
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:MWHPR04MB0480;
x-ms-traffictypediagnostic: MWHPR04MB0480:
x-ms-exchange-purlcount: 1
wdcipoutbound: EOP-TRUE
x-microsoft-antispam-prvs: <MWHPR04MB0480F0A0391C9B46280DDA3A90680@MWHPR04MB0480.namprd04.prod.outlook.com>
x-forefront-prvs: 0941B96580
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(136003)(346002)(396003)(39860400002)(366004)(199004)(189003)(8676002)(97736004)(106356001)(2351001)(26005)(256004)(102836004)(186003)(105586002)(53936002)(386003)(7736002)(2906002)(6506007)(2501003)(81166006)(81156014)(6306002)(305945005)(50226002)(36756003)(66066001)(99286004)(6512007)(8936002)(52116002)(54906003)(966005)(6486002)(6436002)(316002)(5640700003)(6116002)(3846002)(6916009)(25786009)(72206003)(4326008)(2616005)(68736007)(71190400001)(476003)(71200400001)(478600001)(86362001)(44832011)(1076003)(486006)(14454004);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR04MB0480;H:MWHPR04MB0401.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: dgTtLyzvGDdDKYGzaVKi2s/MXJrM0oAJxJKHhkLksKUxJ56fnkM+UGUrN0+AYEdimmAmf9QkSTp8m7IJIShV9oh4yHFwoSc5LTiHgOzasp53Q14w9YQtfWjbwMOuC/vubCtHtJvI8Lq29GBguBRO4HfmNmy1+fGzWaqmZP/wawQ7mnGEiq4cAVvKUzWr+0EdOU5xp5rdo7hbqVs5f6X4N4sKQ6P6k2BNP+5JYRzS+gojJPBSJG0cQs20Ky62fGgyhxU54vkJiaEMYiT/jAQYnWrmwo+Za3mf9rzOkrrOIELiRH1XCfmbkMvpPR0Yr1XJDdtZ2m9Lgy4lfZYyNW9dfn960mM1Feqi3NarjjNKiQEJAyweMzxr7ofx5SL9ngUzwUlWx3MWjjiSlHD6HQ/wCoyNiuWSVK04cLQK2q0NeNg=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d518c8e-6c99-4663-3d1d-08d68d4f6c08
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2019 22:55:57.2064
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0480
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To fix systemd/sysVinit crashes enable __ARCH_WANT_STAT64.

systemd failed to start with this error for 32-bit RISC-V:
[    2.833864] Run /sbin/init as init process
/sbin/init: error while loading shared libraries: libsystemd-shared-239.so:=
 cannot stat shared object: Error 38
[    2.933593] Kernel panic - not syncing: Attempted to kill init! exitcode=
=3D0x00007f00
[    2.934120] CPU: 0 PID: 1 Comm: init Not tainted 5.0.0-rc4-yoctodev-stan=
dard #1
[    2.934589] Call Trace:
[    2.934919] [<c0048a30>] walk_stackframe+0x0/0xa0
[    2.935243] [<c0048c14>] show_stack+0x28/0x32
[    2.935518] [<c05fa418>] dump_stack+0x68/0x88
[    2.935788] [<c004de48>] panic+0xf0/0x252
[    2.936041] [<c0051780>] do_exit+0x7de/0x7fc
[    2.936387] [<c00517f4>] do_group_exit+0x2a/0x82
[    2.936674] [<c005185e>] __wake_up_parent+0x0/0x22
[    2.936982] [<c00475fa>] ret_from_syscall+0x0/0xe
[    2.937673] ---[ end Kernel panic - not syncing: Attempted to kill init!=
 exitcode=3D0x00007f00 ]---

sysVinit had a similar problem as well. By enabling __ARCH_WANT_STAT64
for 32-bit RISC-V the problem disapears and 32-bit RISC-V is able to
boot.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
This was tested with this fork of glibc to enable 32-bit RISC-V support:
https://github.com/riscv/riscv-glibc/tree/riscv-glibc-2.29
commit: 04fdd476160a55792a75375ba2bf56c761f811c2

I'm not sure if this is a glibc problem or a kernel problem, but this
commit caused the breakage between the 4.19 and 4.20 kernel so I'm
sending out a patch. Let me know your thoughts

arch/riscv/include/uapi/asm/unistd.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/riscv/include/uapi/asm/unistd.h b/arch/riscv/include/uapi=
/asm/unistd.h
index 1f3bd3ebbb0d..031b7d78e11c 100644
--- a/arch/riscv/include/uapi/asm/unistd.h
+++ b/arch/riscv/include/uapi/asm/unistd.h
@@ -20,6 +20,9 @@
 #endif /* __LP64__ */
=20
 #include <asm-generic/unistd.h>
+#if __BITS_PER_LONG =3D=3D 32
+#define __ARCH_WANT_STAT64
+#endif
=20
 /*
  * Allows the instruction cache to be flushed from userspace.  Despite RIS=
C-V
--=20
2.20.1