Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1015814imj; Thu, 7 Feb 2019 16:02:18 -0800 (PST) X-Google-Smtp-Source: AHgI3IZT/G1F84Jp4M24100V4qiZBNcmIAOvdkUCP/m2x5TQQ3/H3Sg/cH4ZkR4qOLTL+KKpJ3EN X-Received: by 2002:a63:ef04:: with SMTP id u4mr17571367pgh.197.1549584138801; Thu, 07 Feb 2019 16:02:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549584138; cv=none; d=google.com; s=arc-20160816; b=v9y1KDGWNGL2hJiPbfPhWB9wO8rl5m0BgQh5hzv9DaLuVftcf/0wlK6f05Cnt5QvwJ Z2+esXFGbKTYEnlwZpdfjRQo7EnR6XTnnbTUJEe7Gw4JyYcebhzDptQuB90FFU2QLKXW cpGrTM7ZjU1B0fPXE6d3xNKvIm8vkNZ0bA7dpomkqjaSSSco5WT6fKflH8v/IZrRlgWN EWtVFOQtVKC/GTDl7NyJdUWngWdsU+LnluwlG++9ih80NQNUKTkbfXQW3Ty7wJ0h0ZOa u+G6tLQ6hC2Nv/eao4OnWbmYMNvB3Tn+a1kWuIhKIR5grM+7IfP0BHRAWuv/Kwz4OdLk kPRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=Q08blxnkX/VNLjbDdifa1q1/CqzE5wTUvZFrw3nbrB0=; b=hS2vDKmPm1n/EHEVCg0mCNUzlQneSn5p7JPzwY1mJlducac/qIH8snZ8u7f+QIxRDb fJ5UZnys3Roq5H555/ltHpFo/jSgIaaeTAx07FRLAK46j+iVOeIRRS75GObdPonnp028 KSWLZS5O97AU0wpOztQG2rXGy7vSXfZ1LxqyxHogCCkplbznHRjSgjM8pqgWoKsmvcUs VxHluLChUqRahw8TGJc2fkJwBWl5iUUuafyEI3r9BWFV1JQmzMwq28FTG+hijvhiN8W2 K7yuF3Hf4cxmMBeMOmdU4jC2qxFkP5skVACDalrXHDyjlfDE8Ru8q4gC/ANDeoaKi2GN oxUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=TNQ20UIX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si335527pgp.260.2019.02.07.16.02.02; Thu, 07 Feb 2019 16:02:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=TNQ20UIX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbfBHABi (ORCPT + 99 others); Thu, 7 Feb 2019 19:01:38 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:40205 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbfBHABf (ORCPT ); Thu, 7 Feb 2019 19:01:35 -0500 Received: by mail-yb1-f196.google.com with SMTP id y13so729181ybr.7 for ; Thu, 07 Feb 2019 16:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=Q08blxnkX/VNLjbDdifa1q1/CqzE5wTUvZFrw3nbrB0=; b=TNQ20UIX8LlosZRnx38Lexd4cmULtA3Roy1ugKNFxiGDqy33k7tLK9Ke93Bzb1xX0O PbIVIV52nK9zLq4DXf8JhAxlK4ZC0XGDU0kHdDhGO9W5wULtn1Vde3To6a+NuWFn6Z68 TrRFh+dopgnPc1Msspm4VnfZZER/YmVyH9OWg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q08blxnkX/VNLjbDdifa1q1/CqzE5wTUvZFrw3nbrB0=; b=IDhQ4A0F911yZnxqnIBi2jnkP6s04cp0+KxvKqahGlOO3UwSuh1t8r9J6QWML8xgBr MUk2fR1Mx7hNyAJthP6BcXDC9CajMV4yE0PTdnFuqYbja+Ll1lby1IRc6Nzne38kdWUR 7sq1fO+HcapniViFHIyTFJCWtdeJ/ojLbFWXv+WtMG3XIuqlzTY2Jzy43RMjQ2Xkng8L mAgw5/8Yq3KxtV22910m9WQfUyWXBO8HvdvyNYvEcM+/cbVSQvGoeTHDyvGj7zuLmJtO 0spBrv+NtxCOGogmwMhA7+eYEU4HHcs0b8dhbkqs7Ux29HcC//ahPqT4BXkKjMD6fcFk gxLg== X-Gm-Message-State: AHQUAuYRBc3s1bjCcN+wlIi4Zz2gBneXNWV40TEh9VvIAFJV/xWHOQTp mAtLjMrpQl1bpc/0YdStW5Z6Gw== X-Received: by 2002:a25:40e:: with SMTP id 14mr2262198ybe.42.1549584094327; Thu, 07 Feb 2019 16:01:34 -0800 (PST) Received: from lbrmn-lnxub86.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id 141sm161050yws.47.2019.02.07.16.01.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 16:01:33 -0800 (PST) From: Arun Parameswaran To: Florian Fainelli , Andrew Lunn , Vivien Didelot , "David S . Miller" Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arun Parameswaran Subject: [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt Date: Thu, 7 Feb 2019 16:01:18 -0800 Message-Id: <20190208000118.9268-1-arun.parameswaran@broadcom.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the issues with non BCM58XX chips in the b53 driver failing, when the irq is not specified in the device tree. Removed the check for BCM58XX in b53_srab_prepare_irq(), so the 'port->irq' will be set to '-EXIO' if the irq is not specified in the device tree. Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts") Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized") Signed-off-by: Arun Parameswaran --- drivers/net/dsa/b53/b53_srab.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c index 90f514252987..d9c56a779c08 100644 --- a/drivers/net/dsa/b53/b53_srab.c +++ b/drivers/net/dsa/b53/b53_srab.c @@ -511,9 +511,6 @@ static void b53_srab_prepare_irq(struct platform_device *pdev) /* Clear all pending interrupts */ writel(0xffffffff, priv->regs + B53_SRAB_INTR); - if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID) - return; - for (i = 0; i < B53_N_PORTS; i++) { port = &priv->port_intrs[i]; -- 2.17.1