Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1127868imj; Thu, 7 Feb 2019 18:19:41 -0800 (PST) X-Google-Smtp-Source: AHgI3IYjbH10OYdrswTnDVlp6DSZROOd15713aPjNLAff8gCptli7mReVP+wXUzxj9rVK4eApB2c X-Received: by 2002:a62:4bcf:: with SMTP id d76mr20330460pfj.170.1549592380998; Thu, 07 Feb 2019 18:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549592380; cv=none; d=google.com; s=arc-20160816; b=Z8OVZrsV2PvgkQge0ssrQwDRpUgiYh2AUNC/pzyC0VHeyHS5BxmAy2n950Ec4eY8DC 5zu0aOm2uOZ9Sj9DITGrLit8qpJipEalwqt3kT+XTHDN3qMBG7AsxzchvjvBrr0tcmtx pcntynWf32WiqSd8UCqxCkRH7BEzhUGH2XXdH3On7T2hXlOlpVQdF3hLCvu3Ix8NmTKD YufAllGeMQEX08oObDgV/+P5MpdVPjId6iUXX3CUT2Hv8WEjPBlLwys32g5QzXUHaCmX 3sSWdqvXfI3XE/CueXaFYHKiVY/2dqMs5nWrz2kghSM5JxcCKTzpEDE4ZYKxqDNO2PNo l8OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=j5mUcE9GC7Mo/UcMYCGnU40Im1BziD8kAz7s4Aw2Q3Y=; b=qtrkVWtHJEcQiqmBHeP6Kt/qR7mpnJtzbX9FtJfinN0Upp8AYf9u2hfzsy/AAD87/w gUoLT6WnsANq8IYOnggXGruhYJH3sSvChLeMC9iaUA0v439Sfcv7XXFm5VK/RNjinfwH V10id3vqDOg8bl+0axO+KgBlPG9E96XTb0HZH3+jpKOG401QxHAaSmtLc5t0VDzblkPo 6SzQzWhZOwGlcPqNkaE8HUMAz3pMvcvigo6FcKhG+JDuoAQcwmpFbrX7r3GKjujBizDB Acx/7RsDQlzN+qb6B/+CKsWgkBXdv1sPf90T9EgEbTxsUqq2cADad2I5lMgRjo87xeEv UfhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d125si747471pfc.114.2019.02.07.18.19.25; Thu, 07 Feb 2019 18:19:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbfBHCTT (ORCPT + 99 others); Thu, 7 Feb 2019 21:19:19 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbfBHCTT (ORCPT ); Thu, 7 Feb 2019 21:19:19 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 781D8108B8734; Thu, 7 Feb 2019 18:19:18 -0800 (PST) Date: Thu, 07 Feb 2019 18:19:18 -0800 (PST) Message-Id: <20190207.181918.1582739067793552076.davem@davemloft.net> To: arun.parameswaran@broadcom.com Cc: f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net: dsa: b53: Fix for failure when irq is not defined in dt From: David Miller In-Reply-To: <20190208000118.9268-1-arun.parameswaran@broadcom.com> References: <20190208000118.9268-1-arun.parameswaran@broadcom.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Feb 2019 18:19:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arun Parameswaran Date: Thu, 7 Feb 2019 16:01:18 -0800 > Fixes the issues with non BCM58XX chips in the b53 driver > failing, when the irq is not specified in the device tree. > > Removed the check for BCM58XX in b53_srab_prepare_irq(), > so the 'port->irq' will be set to '-EXIO' if the irq is not > specified in the device tree. > > Fixes: 16994374a6fc ("net: dsa: b53: Make SRAB driver manage port interrupts") > Fixes: b2ddc48a81b5 ("net: dsa: b53: Do not fail when IRQ are not initialized") > Signed-off-by: Arun Parameswaran Applied and queued up for -stable, thanks.