Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1392612imj; Fri, 8 Feb 2019 00:19:04 -0800 (PST) X-Google-Smtp-Source: AHgI3IbOgJyZOvVt5pm3b837oFl8CfrnE9sL4Cf97pFdFiy82mLX5XnPFlIEdXFvvSkOy1+R8+qY X-Received: by 2002:a63:484c:: with SMTP id x12mr19137649pgk.375.1549613943877; Fri, 08 Feb 2019 00:19:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549613943; cv=none; d=google.com; s=arc-20160816; b=S+6SKoxe8NCgWqvJQuu5P4hNgN10P2ZC68r0jNFL6WvA5PasUeIsa/PuArA55bf/VK DW1P6802DlaPNpKUjeJ5Ve0o/6g4MzYapV97XZN1LUznTMqMYDkmdY9G4VmCl1E2x0oB m7cHKcfTt59d5XBaV9MhBTceTqY8g+CVoAaNTfYtimR2AQchQMaR31Y3lmjHOcIzfte9 pdIaM0wMtq2H9MR88Br0/tMme9zS6qXR+h7Do4UZMbLDzsw3esR1UtU7zrenzi9dHmtE NHv1GBVyiCDpTRO5/ygi1BBriabvnRtxVRZuRAWk5tDpUdATndZIIAIFfJ6D+cwo02cg 2tww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HCB63srv2dZIavCQE8QCNeWaSpOPvhtRoJPZWCpNd44=; b=0z4vcI2cwHGKbCLNY+uD6JHfpnLYdUhZF9TU3KhN92KEYrFnXq+kI7q+qZuaXvUffk sUaNDLsOf3pxTTfICTw0Jru7EfIuvdp0D5sCHRss9ip+AoJA3BaWpu6zJdwB2dTz+DSk 54qUELK3wDvrQvftSCLx+mn8WgHwLVCY4Lex80CRcEqT+d3OLq2mT1oVDMofAtqX5F6N rILu6fwFrJlbklobtTW/vCSmHvmTbtmxYx0oAVEQ4uV7OScqwx842Jd9k/9740dCcTbk Vb509hZwC4TSPOOcamLnwBFqL0HwTWHgTfi+dGwo7OlRBAkUACZAoQv1Jo681fI/AAd2 T9mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=c+ub+vtc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cp14si1735329plb.170.2019.02.08.00.18.47; Fri, 08 Feb 2019 00:19:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=c+ub+vtc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727284AbfBHISm (ORCPT + 99 others); Fri, 8 Feb 2019 03:18:42 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.82]:34095 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727166AbfBHISm (ORCPT ); Fri, 8 Feb 2019 03:18:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1549613919; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=HCB63srv2dZIavCQE8QCNeWaSpOPvhtRoJPZWCpNd44=; b=c+ub+vtcXDBYUlmA0egusm0q8ZNb1hPqYCiAG2OjE4WChAX6Um6VoLlgSYwfY1XlZY FMUsW6SVZLmLr/NOUpgP7WSVrvzM8aHEkW7LEBKBmTeUtrQ95itXf7X0ihTgqdF8Z93p tGRfWHMGgoXNlzzmQOtTqtoTph4kySJe/7gMkG4AwVCXEXAWkUQJY9NTqeIAcN4zk+DY 4sy0rz60FL/yBRktewDBKMg3EDvN+av9jGw/+67aHD51K5XPkR7cRtgAXIWBgwHJEpgN DWXjAcjU/7LzcMB1Hb4tSRLGyqGUTXNKlqnHg0Otk+nif+dLB5AR300pzCV7u4QvmMFZ y6NA== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzHHXDaIPSfWeq9" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id 309bcfv188Ho76p (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 8 Feb 2019 09:17:50 +0100 (CET) From: Stephan Mueller To: Herbert Xu Cc: Eric Biggers , James Bottomley , Andy Lutomirski , "Lee, Chun-Yi" , "Rafael J . Wysocki" , Pavel Machek , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, keyrings@vger.kernel.org, "Rafael J. Wysocki" , Chen Yu , Oliver Neukum , Ryan Chen , David Howells , Giovanni Gherdovich , Randy Dunlap , Jann Horn , Andy Lutomirski , linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 0/6] General Key Derivation Function Support Date: Fri, 08 Feb 2019 09:17:50 +0100 Message-ID: <2047284.dgeq8KlW64@tauon.chronox.de> In-Reply-To: <20190208080547.224fudg2m22d3a6d@gondor.apana.org.au> References: <20190103143227.9138-1-jlee@suse.com> <1798550.XZem68xxzE@tauon.chronox.de> <20190208080547.224fudg2m22d3a6d@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 8. Februar 2019, 09:05:47 CET schrieb Herbert Xu: Hi Herbert, > > > Also, shall we add the signature verification enforcemnt to the helper as > > well? > > What do you mean by that? We need to invoke the function crypto_check_module_sig when the module is loaded. Do you have any concerns invoking it from the module init function? Ciao Stephan