Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1427384imj; Fri, 8 Feb 2019 01:02:54 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia9bu5w+8cQWQlQxAjTHupfGpaamVBHpte7QfBt3QA5CGOSEX5j8EvCpgz1f6tvc4Ks3jUK X-Received: by 2002:aa7:86d1:: with SMTP id h17mr14168515pfo.181.1549616574368; Fri, 08 Feb 2019 01:02:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549616574; cv=none; d=google.com; s=arc-20160816; b=G3z36uo9QJgrjCTxrw9UIMkSLtbsfNQXb6VSj2EvEZ0UZi34tguriA80d7TKXKbbYW nDtkdXhTXgowR2H/PagtR+AplZw1Wi+DLWOSmz1vrTKV4sn7Ilbja25n3AeOvPrl48eq maDDGCq++eCGAn7f1+qncT1IeZR1bggJqAScAon3FC0mj+VYYRA7Z8QLIcdZqrqrtdQW 3yL+aCc24R6uonGkPXKpuXzS2F2DqBGyxiedbH5fgv1jTPPIL3XXCBXmwi/FBTWDdClK 9hQO/whwJpYBRqefpz6k+aQrE/O4AdVO7BbE0cqFp3SaO1cQHkIkBKM5Akd6EXhLkIUE 5E4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature; bh=fooRh1gZ6IpLFzGD2jk4xEF8/2O5k1pY3XR60x9luIk=; b=JYbDNUnCK3L2ZNvzH2W0TcOk4boThO/sf/ZK8wxD5oajuNuDJtOIXgaiC+XCstArhm Ej5OkQPHQuIZ6FYSPTvQaz1qHfEZ0duqqxjPClE7jCGzAN/rE9S3WAfOH9eHz8/Ql7ne mOuISPEo5E8q1DYif15AyIT11T20RtHFIsBzN4qG9Q6fW5+iVw++Se01QGakt3PHOk94 c+39rPpadlL2GFSlMf+gYW3QK3CgU41FmMvTx7/43dfjCD6xa/Iw9lv4LpFjvqiP0qvt ISU1/VzlsWkqHcXEP8WJpUOe1kEuh6Od8fpiBDdSmV6Rg/Ss6Bf+f3PYMfqeA02sFqJ5 XtHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=Yxwh+Xmw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci1si1886346plb.352.2019.02.08.01.02.38; Fri, 08 Feb 2019 01:02:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=Yxwh+Xmw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727457AbfBHJBz (ORCPT + 99 others); Fri, 8 Feb 2019 04:01:55 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.167]:18145 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727436AbfBHJBy (ORCPT ); Fri, 8 Feb 2019 04:01:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1549616509; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:References:Cc:To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=fooRh1gZ6IpLFzGD2jk4xEF8/2O5k1pY3XR60x9luIk=; b=Yxwh+XmwzxXbQSSQKH9sTuNMSDM/cEqZLvky01WbB/IYAzMfVaflvlJsI3Z187YCgS CoIdtVulZaZF6jnl+NWSvm/l7TZyeLzfNcFQYQfg0ChdxE0V2trKA4oPULmG1yfb0GT3 VCjMSTZFCrXmxMAFbqQOZao9ejaQk0AC6mEIPorGt80WSYNlDq0xXiVEYduxmwF6c6ki F7/7R3cHUQfMqb8S25ouNSj3zjol1eo86pYqtXH3cF8y/PNruuwMaEQqQ+Ex2PNKpHzn doKrKtq1qXyrblgHDzBrsLi/oXoV6cfiSpWyZR13JKMx6DAYXC/vOfLspysuNsytYQme Iqzg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5G5MdirQj0WG7CkGj+Y7E+ydJaUNFx8xLfqBQFoUyw==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:a400:162c:914e:ec0c:daf0:5a2a] by smtp.strato.de (RZmta 44.9 AUTH) with ESMTPSA id t0203dv1891k4iY (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 8 Feb 2019 10:01:46 +0100 (CET) Subject: Re: use generic DMA mapping code in powerpc V4 From: Christian Zigotzky To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org References: <96762cd2-65fc-bce5-8c5b-c03bc3baf0a1@xenosoft.de> <20190201080456.GA15456@lst.de> <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> <20190206151505.GA31065@lst.de> <20190206151655.GA31172@lst.de> <61EC67B1-12EF-42B6-B69B-B59F9E4FC474@xenosoft.de> Message-ID: <7c1f208b-6909-3b0a-f9f9-38ff1ac3d617@xenosoft.de> Date: Fri, 8 Feb 2019 10:01:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <61EC67B1-12EF-42B6-B69B-B59F9E4FC474@xenosoft.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, Your new patch fixes the problems with the P.A. Semi Ethernet! :-) Thanks, Christian On 07 February 2019 at 05:34AM, Christian Zigotzky wrote: > Hi Christoph, > > I also didn’t notice the 32-bit DMA mask in your patch. I have to read your patches and descriptions carefully in the future. I will test your new patch at the weekend. > > Thanks, > Christian > > Sent from my iPhone > >> On 6. Feb 2019, at 16:16, Christoph Hellwig wrote: >> >>> On Wed, Feb 06, 2019 at 04:15:05PM +0100, Christoph Hellwig wrote: >>> The last good one was 29e7e2287e196f48fe5d2a6e017617723ea979bf >>> ("dma-direct: we might need GFP_DMA for 32-bit dma masks"), if I >>> remember correctly. powerpc/dma: use the dma_direct mapping routines >>> was the one that you said makes the pasemi ethernet stop working. >>> >>> Can you post the dmesg from the failing runs? >> But I just noticed I sent you a wrong patch - the pasemi ethernet >> should set a 64-bit DMA mask, not 32-bit. Updated version below, >> 32-bit would just keep the previous status quo. >> >> commit 6c8f88045dee35933337b9ce2ea5371eee37073a >> Author: Christoph Hellwig >> Date: Mon Feb 4 13:38:22 2019 +0100 >> >> pasemi WIP >> >> diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c >> index 8a31a02c9f47..2d7d1589490a 100644 >> --- a/drivers/net/ethernet/pasemi/pasemi_mac.c >> +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c >> @@ -1716,6 +1716,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >> err = -ENODEV; >> goto out; >> } >> + dma_set_mask(&mac->dma_pdev->dev, DMA_BIT_MASK(64)); >> >> mac->iob_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa001, NULL); >> if (!mac->iob_pdev) {