Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Feb 2019 12:13:35 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nadav Amit <namit@vmware.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Julien Freche <jfreche@vmware.com>
Subject: Re: [PATCH 2/6] vmw_balloon: support 64-bit memory limit
Message-ID: <20190208111335.GA3632@kroah.com>
References: <20190206235706.4851-1-namit@vmware.com>
 <20190206235706.4851-3-namit@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190206235706.4851-3-namit@vmware.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 06, 2019 at 03:57:02PM -0800, Nadav Amit wrote:
> From: Xavier Deguillard <xdeguillard@vmware.com>
> 
> Currently, the balloon driver would fail to run if memory is greater
> than 16TB of vRAM. Previous patches have already converted the balloon
> target and size to 64-bit, so all that is left to do add is to avoid
> asserting memory is smaller than 16TB if the hypervisor supports 64-bits
> target.
> 
> The driver advertises a new capability VMW_BALLOON_64_BITS_TARGET.
> Hypervisors that support 16TB of memory or more will report that this
> capability is enabled.
> 
> Signed-off-by: Xavier Deguillard <xdeguillard@vmware.com>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
>  drivers/misc/vmw_balloon.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index c4371ec132d3..f96dc3690ade 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -72,15 +72,26 @@ enum vmwballoon_capabilities {
>  	VMW_BALLOON_BATCHED_CMDS		= (1 << 2),
>  	VMW_BALLOON_BATCHED_2M_CMDS		= (1 << 3),
>  	VMW_BALLOON_SIGNALLED_WAKEUP_CMD	= (1 << 4),
> +	VMW_BALLOON_64_BIT_TARGET		= (1 << 5)

Nit, this should be BIT(5), right?

You can change that in a later patch...

thanks,

greg k-h