Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262254AbUCJFfa (ORCPT ); Wed, 10 Mar 2004 00:35:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262260AbUCJFf3 (ORCPT ); Wed, 10 Mar 2004 00:35:29 -0500 Received: from fw.osdl.org ([65.172.181.6]:24550 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262254AbUCJFfV (ORCPT ); Wed, 10 Mar 2004 00:35:21 -0500 Date: Tue, 9 Mar 2004 21:35:18 -0800 From: Andrew Morton To: Nick Piggin Cc: schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: blk_congestion_wait racy? Message-Id: <20040309213518.44adb33d.akpm@osdl.org> In-Reply-To: <404EA645.8010900@cyberone.com.au> References: <404EA645.8010900@cyberone.com.au> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 17 Nick Piggin wrote: > > But I'm guessing that you have no requests in flight by the time > blk_congestion_wait gets called, so nothing ever gets kicked. That's why blk_congestion_wait() in -mm propagates the schedule_timeout() return value. You can do: if (blk_congestion_wait(...)) printk("ouch\n"); If your kernel says ouch much, we have a problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/