Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1702351imj; Fri, 8 Feb 2019 06:04:34 -0800 (PST) X-Google-Smtp-Source: AHgI3IYTlkd+2Wgw+qzlKtBIanZkw9GjiNCM5128jlM4CcfkQekLE1/Ti9wlvV1Z52rP1FJT9DVG X-Received: by 2002:a17:902:28aa:: with SMTP id f39mr22979889plb.297.1549634674880; Fri, 08 Feb 2019 06:04:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549634674; cv=none; d=google.com; s=arc-20160816; b=c0K/t0X3qvzkJTFEDSyEh9sRIn9uqbQVo0Gq/jczV+v7jNhDpGy+tbViwu7sfY6hxf 2RoR7PVvPWthgFKcRj8YRzxbuUFlth0afrxW3xYovBP6mCBD6bvmvvIgjAfogIyqmVIT YW3xVNusyC1VH8RwhNlZwW376z3px1zj6/hRwIxxu2lUPGtVU64PJgERjOhiahwFH+Gd 4UlUH89ECkkKVfeJhE1IBeDfFwrqgWLCgDReLgVuR1k72+g0y9duQM0QrhAWXfP/yFrR +2zlrNnsam84idgwvqUKj1Kzl8HerdLPncwldKvCCSqDE47Qt0hiDILNY5S8q+r5+w83 uXAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=2HdFIaLKYuwxiPvsPl9mdufygdSVy95iRnDY+4ACiek=; b=wRwGOrpW7saUfVLTLnG2fcuMnlb2E8faFYln0Biu+qgateRijP46HxGwCSCQa5h7v0 zDV1jvBrRaNycXkrZdMSMx+zmJSri3WH+Q+z67YLMSCOGPID//U2rCMeAQdk70e+/Ofs 00YZQp+raL/ymyzdzpeSfJWqPffhE5q7wieLx2APgiciYt4H3uqlZ0/t2XCsWneC8ZGE XFc+s0cDAkgcAffAhjNV82gSbDWnzfNud5TSMeztgeLE5pEDpdYSfqIFZZMIE6G1HKZs xnjxQ0MAMicHkr08UwyrelWk8D9/TWoRDpK81JJgTQm4B9zIvMcfNIlnG8pPB5lYWf80 JAig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si110239pgm.129.2019.02.08.06.04.16; Fri, 08 Feb 2019 06:04:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbfBHOCa (ORCPT + 99 others); Fri, 8 Feb 2019 09:02:30 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47744 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727677AbfBHOCa (ORCPT ); Fri, 8 Feb 2019 09:02:30 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x18E08xR109923 for ; Fri, 8 Feb 2019 09:02:29 -0500 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qhb52g5ep-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Feb 2019 09:02:28 -0500 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Feb 2019 14:02:28 -0000 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 8 Feb 2019 14:02:24 -0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x18E2Okk29032592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Feb 2019 14:02:24 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E17937806A; Fri, 8 Feb 2019 14:02:23 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 81FEC7806E; Fri, 8 Feb 2019 14:02:22 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 8 Feb 2019 14:02:22 +0000 (GMT) Subject: Re: [PATCH v11 00/16] Remove nested TPM operations To: Jarkko Sakkinen Cc: Alexander Steffen , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Tomas Winkler , Tadeusz Struk , Stefan Berger , Nayna Jain References: <3d6fdcc1-8221-2137-fc82-596377cc2fdc@infineon.com> <20190207212912.GD23906@linux.intel.com> <0af40351-91d5-d0a7-2965-0a9c6505af79@linux.ibm.com> <20190208003314.GB7202@linux.intel.com> <1fbd29ad-1005-8450-4c39-00974468183b@linux.ibm.com> <20190208111442.GA11755@linux.intel.com> <06473b24-7c59-9405-bbe0-8d30b3450391@linux.ibm.com> <20190208130227.GA16679@linux.intel.com> <20190208131754.GA18133@linux.intel.com> <20190208133355.GA18774@linux.intel.com> From: Stefan Berger Date: Fri, 8 Feb 2019 09:02:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190208133355.GA18774@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-MW X-TM-AS-GCONF: 00 x-cbid: 19020814-0020-0000-0000-00000EB89A20 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010559; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000279; SDB=6.01158098; UDB=6.00604243; IPR=6.00938630; MB=3.00025494; MTD=3.00000008; XFM=3.00000015; UTC=2019-02-08 14:02:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19020814-0021-0000-0000-000064B9401E Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=714 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902080099 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/8/19 8:33 AM, Jarkko Sakkinen wrote: > > if (len != be32_to_cpu(header->length)) { > rc = -EFAULT; > goto out; > } > > rc = tpm2_commit_space(chip, space, ordinal, buf, &len); > if (rc) > dev_err(&chip->dev, "tpm2_commit_space: error %d\n", rc); > > That unconditional call to commit space masked the bugs in the device > drivers. I'll provide fixes shortly. You got it! :-) > > /Jarkko >