Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181127103312.19368-1-murphyt7@tcd.ie> <CAMuHMdWX=5CE=vhazBSOEbzJYyAwiK2PSDryCrA67yXRVb0m3w@mail.gmail.com>
In-Reply-To: <CAMuHMdWX=5CE=vhazBSOEbzJYyAwiK2PSDryCrA67yXRVb0m3w@mail.gmail.com>
From:   Tom Murphy <murphyt7@tcd.ie>
Date:   Fri, 8 Feb 2019 14:31:07 +0000
Message-ID: <CALQxJusnECzqS+Hn-TgfJnXKw--MbfB8DizrjYanejfDdA=gRA@mail.gmail.com>
Subject: Re: [PATCH] fix dma-buf/udmabuf selftest
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> However, we need <linux/fcntl.h> for F_ADD_SEALS, F_SEAL_SHRINK.
>
> Including both leads to lots of redefinition warnings.
>
> Can we fix that?

I still haven't looked at this and probably won't get a chance anytime soon=
.
linux/tools/testing/selftests/memfd/fuse_test.c also suffers from this
(it needs the F_ADD_SEALS too) so that should also be fixed if anyone
gets a chance


On Wed, 9 Jan 2019 at 10:44, Geert Uytterhoeven <geert@linux-m68k.org> wrot=
e:
>
> Hi Tom,
>
> On Tue, Nov 27, 2018 at 7:53 PM Tom Murphy <murphyt7@tcd.ie> wrote:
> > This patch fixes the udmabuf selftest. Currently the selftest is broken=
.
> > I fixed the selftest by setting the F_SEAL_SHRINK seal on the memfd
> > file descriptor which is required by udmabuf and added the test to
> > the selftest Makefile.
> >
> > Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
>
> This is now commit 6edf2e3710f4ef25 ("fix dma-buf/udmabuf selftest").
>
> > --- a/tools/testing/selftests/drivers/dma-buf/udmabuf.c
> > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c
> > @@ -4,7 +4,7 @@
> >  #include <unistd.h>
> >  #include <string.h>
> >  #include <errno.h>
> > -#include <fcntl.h>
> > +#include <linux/fcntl.h>
>
> Not including <fcntl.h> means we get
>
> udmabuf.c:30:10: warning: implicit declaration of function =E2=80=98open=
=E2=80=99; did
> you mean =E2=80=98popen=E2=80=99? [-Wimplicit-function-declaration]
>   devfd =3D open("/dev/udmabuf", O_RDWR);
> udmabuf.c:42:8: warning: implicit declaration of function =E2=80=98fcntl=
=E2=80=99; did
> you mean =E2=80=98fcvt=E2=80=99? [-Wimplicit-function-declaration]
>    ret =3D fcntl(memfd, F_ADD_SEALS, F_SEAL_SHRINK);
>
> However, we need <linux/fcntl.h> for F_ADD_SEALS, F_SEAL_SHRINK.
>
> Including both leads to lots of redefinition warnings.
>
> Can we fix that?
>
> >  #include <malloc.h>
> >
> >  #include <sys/ioctl.h>
> > @@ -33,12 +33,19 @@ int main(int argc, char *argv[])
> >                 exit(77);
> >         }
> >
> > -       memfd =3D memfd_create("udmabuf-test", MFD_CLOEXEC);
> > +       memfd =3D memfd_create("udmabuf-test", MFD_ALLOW_SEALING);
> >         if (memfd < 0) {
> >                 printf("%s: [skip,no-memfd]\n", TEST_PREFIX);
> >                 exit(77);
> >         }
> >
> > +       ret =3D fcntl(memfd, F_ADD_SEALS, F_SEAL_SHRINK);
> > +       if (ret < 0) {
> > +               printf("%s: [skip,fcntl-add-seals]\n", TEST_PREFIX);
> > +               exit(77);
> > +       }
> > +
> > +
> >         size =3D getpagesize() * NUM_PAGES;
> >         ret =3D ftruncate(memfd, size);
> >         if (ret =3D=3D -1) {
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org
>
> In personal conversations with technical people, I call myself a hacker. =
But
> when I'm talking to journalists I just say "programmer" or something like=
 that.
>                                 -- Linus Torvalds