Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1852803imj; Fri, 8 Feb 2019 08:22:48 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib1riMlWKBACSl3UUholU2bus9l088Vf0CO9j+GsHiXv19oY+RHFARq3GNTDhnrCxQ6Paaw X-Received: by 2002:a62:26c7:: with SMTP id m190mr23369009pfm.79.1549642968523; Fri, 08 Feb 2019 08:22:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549642968; cv=none; d=google.com; s=arc-20160816; b=OeMendVQmxVlIfRnUXUFrup7kpWUFO+dhnxXE2NWro2xjS8HE+0ywNBD7Zt+yoTOLs ItAEU5kXg/v8h3tYLJgsJmYXx0W0IFuprUZ/wQh8bCyxBGr91zigYJmRQ0X9snQCfBS3 /ZhVDpN7sgq7opnLkTrKtbOZHUPqUJ6xZtsWl9i3UFaEavT/j6tyamThtsJANy7gbKRP jM8OFj0eyQ4hLrPi+GMd37ky5lR3e1wk5hCghrFPEO5U8+uApuT+WU0bXX/RzbWkr503 V3GwwOcZHwyqic3pKB+NV0jR+b9Dd38/dGzs6GaZ+TW/JKlnQMyWxyUa1J6Bynvj9nki /d2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MJih/aqmx9MgDhFAv4mEd0Lpp8a8n6K7Ehg4K+XvQ5U=; b=tjBvmGJXFJ0lHKVH+nySB6DCRLIOmUeAo7fUAqE8KJZ+nlTtqH2AHGBjzLDLqUcF8d RT33ScnODCzk+qTuGQUXJ4AaZrOXo67SLhO2CEI2n9XtB6vdgh/UOHG94mo+XE1e1JsO TRmNtdAiUVlFO5djONnbjVBFBrAkS0LH8xA3iR+XW8wjctaZVXWLodbHKnIFIRDCaWwA Sjh6EqaeqW3UDT2KPUf6cXpv7jGDz0x0B+63huqwMraJyGziHRzGdBiwIR8VTjkxPWXp 5SRCJPLQbUV8ApC3RoyYIrsIIfdvOqLp2jtBt1B9r3CLHoj/l4S3mtRu0Gf9FqQDmyLN rg0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z8nJ64Md; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si2710298plo.102.2019.02.08.08.22.32; Fri, 08 Feb 2019 08:22:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z8nJ64Md; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbfBHQVv (ORCPT + 99 others); Fri, 8 Feb 2019 11:21:51 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:36081 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfBHQVv (ORCPT ); Fri, 8 Feb 2019 11:21:51 -0500 Received: by mail-ot1-f67.google.com with SMTP id k98so6757142otk.3; Fri, 08 Feb 2019 08:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MJih/aqmx9MgDhFAv4mEd0Lpp8a8n6K7Ehg4K+XvQ5U=; b=Z8nJ64Md7tJTNinKsB/iQ2/Ku6zEoeXrATItskdDNe3XqsQkSlwqolMzjvfaRa4tge UY5lKsZe/hDgGjQx9MwWciOciuGRRkfDNYtelBKr6NbrL5Su1XaoZ1JeewfX2escypW+ Km7ctmRJhS3QY1lUhdV2T4Cz20dk+eLMJ1914ma3mM0LKALH3hguz9ibGwjduULEMbrV mWyxu+93ETvvOb5w+z0J05tBjwuP00lbrYUrE3eLNlUtBfP82yMV0hmqX2EMBOF6Uk1h Q1syvPk+fDz0duv4Pi/pIPR9fTtqFPF1aYCNBQN2Xfkm/ZOe3D37U1AZxdRrTR8zP8GQ BvYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MJih/aqmx9MgDhFAv4mEd0Lpp8a8n6K7Ehg4K+XvQ5U=; b=MV7vHfmU3oXOvXSTiOB+4mRGV6k36CGzuFsvZJ/UJ/KhQ2abdjVv2z6FYY4890CSdU +Fvus+ylp4APiZBuDEdY9qUxbsKJYSklk23jeuIvOlYyuHJhPB5sTYCjaBeA/RqhJ65D 6stGCnDf2WoZWUedZh74nVq9GmvvedX2ResssPVQdJjphUPIAVD9BoPDGL33HSPwYHlD JasZsEJo6n+rucr3YPa5QjdQOOlBiNbzZNLs4iAlFBPCeseTT+ZJQDu5Q5Ihne9IrvAp RPVISBycfnPnFgg5CbgA1eAaPfYDtjA0RJJDUcsqQAR7LlxElavTMedznvdCfDVkvUgu 21/Q== X-Gm-Message-State: AHQUAuZjDvQa1dUsyZp+bZGSU6aluQcJGogBNNor5FwbWQscbWhiQO6X 9Ey47ZOzdaHTIDZruhazYQaNIjwmpnwXi42wPjZafA== X-Received: by 2002:a9d:61c8:: with SMTP id h8mr13060008otk.279.1549642910353; Fri, 08 Feb 2019 08:21:50 -0800 (PST) MIME-Version: 1.0 References: <20190207222740.GA38612@dtor-ws> <20190208073102.GA31622@dtor-ws> In-Reply-To: From: Sven Van Asbroeck Date: Fri, 8 Feb 2019 11:21:39 -0500 Message-ID: Subject: Re: [PATCH] Input: ps2-gpio - flush TX work when closing port To: Danilo Krummrich Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 8, 2019 at 10:51 AM Danilo Krummrich wrote: > > I agree with Dmitry > So do I, you guys are absolutely right. As far as I can see, this patch fixes the user-after-free. So, after Dmitry changes flush_work() to flush_delayed_work() : Reviewed-by: Sven Van Asbroeck