Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190130224655.255149-1-tkjos@google.com> <20190208112600.GA22147@kroah.com>
In-Reply-To: <20190208112600.GA22147@kroah.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Fri, 8 Feb 2019 08:44:18 -0800
Message-ID: <CAHRSSEzEW7AfhmrUbUJnL+DFB2sU2X7J8dnnkO6px7Z7BzpE=Q@mail.gmail.com>
Subject: Re: [PATCH v2 0/7] binder: eliminate use of vmalloc space for binder buffers
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Todd Kjos <tkjos@android.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>, joel@joelfernandes.org,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 8, 2019 at 3:26 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jan 30, 2019 at 02:46:48PM -0800, Todd Kjos wrote:
> > Binder buffers have always been mapped into kernel space
> > via map_kernel_range_noflush() to allow the binder driver
> > to modify the buffer before posting to userspace for
> > processing.
> >
> > In recent Android releases, the number of long-running
> > binder processes has increased to the point that for
> > 32-bit systems, there is a risk of running out of
> > vmalloc space.
> >
> > This patch set removes the persistent mapping of the
> > binder buffers into kernel space. Instead, the binder
> > driver creates temporary mappings with kmap() or
> > kmap_atomic() to copy to or from the buffer only when
> > necessary.
>
> This patch series blows up when I apply it to my char-misc-next branch:
>
> drivers/android/binder_alloc_selftest.c: In function =E2=80=98check_buffe=
r_pages_allocated=E2=80=99:
> drivers/android/binder_alloc_selftest.c:108:44: error: =E2=80=98struct bi=
nder_buffer=E2=80=99 has no member named =E2=80=98data=E2=80=99
>   end =3D (void *)PAGE_ALIGN((uintptr_t)buffer->data + size);
>                                             ^~
> Did you forget to enable CONFIG_ANDROID_BINDER_IPC_SELFTEST when doing yo=
ur
> builds?

I did forget. Thanks for catching this. I'll repost with the fix.

-Todd

>
> thanks,
>
> greg k-h