Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1887531imj; Fri, 8 Feb 2019 08:57:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IYnWiilQ/Vu82UtCFRsT9NPJPG44mfuYUY8HxsqgW7BL8wJ7MrAygNeOd95rJkVzCX54HLH X-Received: by 2002:a63:df50:: with SMTP id h16mr357450pgj.421.1549645079692; Fri, 08 Feb 2019 08:57:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549645079; cv=none; d=google.com; s=arc-20160816; b=OrgAi70ChNkZ6u/NnuHRuF8DTPDsIm88KZhxwf6WhCBEbCiy+jTWfEyX84EZC1zQn8 IU5pZSBfoToK7eivk6F5sD67vSmQ4YTBgg6RcSXwtZcKdYYXr+07JO7J1tRAXYCCQWoI IpuQjGNCN7jAZ9ryJbAbr3ZDUyhTrKrkDQGOQk0WIGVAKx/uwFyOnjNbxt+nZEjV3S6w GI8B1VQn9OsMxQ9q5UM4dv0xI8EzVN/v8YTfosOAYkq1U6Men31qhkt0wFG5W8OtNYHX G/wa9Fp+5IwKAzFfy2TQGeEeFckIyw/fU3BAKgqCxloreQSOcOwENL1bwPFYRf5zVPcD HuVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=3tVBw+J7gPya3lgG9w2nBcOd6AG9B7Q2lRN73/FWHTU=; b=aP5bdcLZYkMkRlCaOT3fD+3BM059in1cX6r0MkJDAblF0hp71rzzSD2jy/Y22ok8pM xRdd0PyJEuEX3AryqaxCM5zkB8ex8nnrtZeEUe9a41Xs+BcD+Kw23VRWg9L3mWVFfheE bQDGdW1qO4mUlMIl3GPHeZF62GAhyTHGfte4q2ecVZEE/HA/SWrkUKKzFbJBVWNV75Ft pWNPhL3arOlSLRQtKF/kqSot2f0LVY6LsmDBeD/5m7zNp5R9GPSSxlvySPu2e22EYofU tkM9kcOL8D8L6NFT1/Wi9zECjXHfxHq7vJoUyDPTve3jlKJBt5COYx7cygNT5AyAQU6P iWNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn11si2301010plb.94.2019.02.08.08.57.42; Fri, 08 Feb 2019 08:57:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727174AbfBHQ5g (ORCPT + 99 others); Fri, 8 Feb 2019 11:57:36 -0500 Received: from cloud.peff.net ([104.130.231.41]:37662 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726522AbfBHQ5g (ORCPT ); Fri, 8 Feb 2019 11:57:36 -0500 X-Greylist: delayed 401 seconds by postgrey-1.27 at vger.kernel.org; Fri, 08 Feb 2019 11:57:35 EST Received: (qmail 6048 invoked by uid 109); 8 Feb 2019 16:50:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 08 Feb 2019 16:50:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 25440 invoked by uid 111); 8 Feb 2019 16:51:03 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 08 Feb 2019 11:51:03 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 08 Feb 2019 11:50:52 -0500 Date: Fri, 8 Feb 2019 11:50:52 -0500 From: Jeff King To: "Randall S. Becker" Cc: 'Junio C Hamano' , git@vger.kernel.org, 'Linux Kernel' , git-packagers@googlegroups.com Subject: Re: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop) Message-ID: <20190208165052.GC23461@sigill.intra.peff.net> References: <000f01d4bf9e$a508eab0$ef1ac010$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <000f01d4bf9e$a508eab0$ef1ac010$@nexbridge.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 08, 2019 at 06:08:33AM -0500, Randall S. Becker wrote: > t5318 is rather problematic and I have no good way to fix this. There > is no /dev/zero on the platform, and the corrupt_graph_and_verify > hard-codes if=/dev/zero, which is a linux-specific pseudo device. > Please provide a more platform independent way of testing this > feature. Pretty much all subtests from 46 onward fail as a result. We did discuss this at the time of the patch, but it seems we already use /dev/zero in a bunch of places: https://public-inbox.org/git/xmqqbm57rkg5.fsf@gitster-ct.c.googlers.com/ Were you just skipping the other tests before? -Peff