Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>, LKML <linux-kernel@vger.kernel.org>,
        Julien Freche <jfreche@vmware.com>
Subject: Re: [PATCH 2/6] vmw_balloon: support 64-bit memory limit
Thread-Topic: [PATCH 2/6] vmw_balloon: support 64-bit memory limit
Thread-Index: AQHUvneykVD8LBCmaUCO4sjydkV71qXVwbqAgACUtYA=
Date:   Fri, 8 Feb 2019 20:05:50 +0000
Message-ID: <5C8E9F70-0403-433E-8644-E6505FBE7DEF@vmware.com>
References: <20190206235706.4851-1-namit@vmware.com>
 <20190206235706.4851-3-namit@vmware.com> <20190208111335.GA3632@kroah.com>
In-Reply-To: <20190208111335.GA3632@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D72132A915F9CE4EA0283458949D5D46@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 27e6aa4f-42d1-4c00-55b3-08d68e00d2d6
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2019 20:05:50.5638
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5925
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Feb 8, 2019, at 3:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.or=
g> wrote:
>=20
> On Wed, Feb 06, 2019 at 03:57:02PM -0800, Nadav Amit wrote:
>> From: Xavier Deguillard <xdeguillard@vmware.com>
>>=20
>> Currently, the balloon driver would fail to run if memory is greater
>> than 16TB of vRAM. Previous patches have already converted the balloon
>> target and size to 64-bit, so all that is left to do add is to avoid
>> asserting memory is smaller than 16TB if the hypervisor supports 64-bits
>> target.
>>=20
>> The driver advertises a new capability VMW_BALLOON_64_BITS_TARGET.
>> Hypervisors that support 16TB of memory or more will report that this
>> capability is enabled.
>>=20
>> Signed-off-by: Xavier Deguillard <xdeguillard@vmware.com>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> drivers/misc/vmw_balloon.c | 18 +++++++++++++++---
>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>=20
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index c4371ec132d3..f96dc3690ade 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -72,15 +72,26 @@ enum vmwballoon_capabilities {
>> 	VMW_BALLOON_BATCHED_CMDS		=3D (1 << 2),
>> 	VMW_BALLOON_BATCHED_2M_CMDS		=3D (1 << 3),
>> 	VMW_BALLOON_SIGNALLED_WAKEUP_CMD	=3D (1 << 4),
>> +	VMW_BALLOON_64_BIT_TARGET		=3D (1 << 5)
>=20
> Nit, this should be BIT(5), right?
>=20
> You can change that in a later patch...

Will do.