Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=date:from:to:cc
        :subject:message-id:references:mime-version:content-type
        :in-reply-to:content-transfer-encoding; q=dns; s=sasl; b=jcQn6+5
        N3QKhCjOQ82RVLf6GyRo28PcajNlnsPl3x1s0/YYlec7D5wS9VFXCbNAJlcews6K
        /Zph7DKCTE0y7k8GiVTHdexoqndnZwoSPE9TRsIJwRK9/0rzckdfOXxeXVaABn5C
        akRhAwqN6XhjNFMnAZf/op+HjtfCk17Na5Rs=
Date:   Fri, 8 Feb 2019 15:11:29 -0500
From:   Todd Zullinger <tmz@pobox.com>
To:     SZEDER =?iso-8859-1?Q?G=E1bor?= <szeder.dev@gmail.com>
Cc:     "Randall S. Becker" <rsbecker@nexbridge.com>,
        Jeff King <peff@peff.net>,
        'Junio C Hamano' <gitster@pobox.com>, git@vger.kernel.org,
        'Linux Kernel' <linux-kernel@vger.kernel.org>,
        git-packagers@googlegroups.com
Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)
Message-ID: <20190208201128.GD30548@zaya.teonanacatl.net>
References: <000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com>
 <20190208111002.GU10587@szeder.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20190208111002.GU10587@szeder.dev>
User-Agent: Mutt/1.11.1 (2018-12-01)
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

SZEDER G=E1bor wrote:
> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:
>> We have a few new breakages on the NonStop port in 2.21.0-rc0. The fir=
st is in t5403, as below:
[...]
>> The post-checkout hook is:
>> #!/usr/local/bin/bash
>> echo "$@" >$GIT_DIR/post-checkout.args
>>=20
>> This looks like it is a "bash thing" and $GIT_DIR might have to be in =
quotes, and is not be specific to the platform. If I replace=20
>>=20
>> echo "$@" >$GIT_DIR/post-checkout.args
>>=20
>> with
>>=20
>> echo "$@" >"$GIT_DIR/post-checkout.args"
>>=20
>> The test passes.
>=20
> Wow, this is the second time this "redirection to a filename with
> spaces under Bash" issue pops up today, see the other one here:
>=20
>   https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#=
u

Indeed, I was surprised to see another one today.

It made me wonder how I had missed it in my own testing.
This one requires SHELL_PATH to be bash, while I only set
TEST_SHELL_PATH to bash for the improved -x tracing in the
fedora builds.

I ran the tests again with SHELL_PATH as bash on fedora and
this was the only failure I saw (other than the one from my
earlier message, that is).

--=20
Todd