Date: Wed, 10 Mar 2004 12:35:01 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Arjan van de Ven <arjanv@redhat.com>, Linus Torvalds <torvalds@osdl.org>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: objrmap-core-1 (rmap removal for file mappings to avoid 4:4 in <=16G machines)
Message-ID: <20040310113501.GA1112@elte.hu>
References: <20040308202433.GA12612@dualathlon.random> <1078781318.4678.9.camel@laptop.fenrus.com> <20040308230845.GD12612@dualathlon.random> <20040309074747.GA8021@elte.hu> <20040309152121.GD8193@dualathlon.random> <20040309153620.GA9012@elte.hu> <20040309163345.GK8193@dualathlon.random> <20040309195752.GA16519@elte.hu> <20040309202744.GS8193@dualathlon.random>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040309202744.GS8193@dualathlon.random>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1612
Lines: 35


* Andrea Arcangeli <andrea@suse.de> wrote:

> the quality of such objrmap patch is still better than rmap. The DoS
> thing is doable with vmtruncate too in any kernel out there.

objrmap for now has a serious problem: test-mmap3.c locked up my box (i
couldnt switch text consoles for 30 minutes when i turned the box off).

I'm sure you'll fix it and i'm looking forward seeing it.  However, i'd
like to see the full fix instead of a promise to have this fixed
sometime the future.  There are valid application workloads that trigger
_worse_ vma patterns than test-mmap3.c does (UML being one such thing,
Oracle with indirect buffer-cache another - i'm sure there are other
apps too.).  Calling these applications 'exploits' doesnt help in
getting this thing fixed.  There's no problem with keeping this patchset
separate until it's regression-free.

> merging objrmap is the first step. Any other effort happens on top of
> it.

i'd like to see that effort combined with this code, and the full
picture.  Since this 'DoS property' is created by the current concept of
the patch, it's not a 'bug' that is easily fixed so we must not (and
cannot) sign up for it blindly, without seeing the full impact.  But
yes, it might be fixable.  Anyway - the 2.6 kernel is a stable tree and
i'm sure you know that avoiding regression is more important than
anything else.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/