Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp116050imj; Fri, 8 Feb 2019 16:12:49 -0800 (PST) X-Google-Smtp-Source: AHgI3IY26Gnf8JumbOQC1/uLdlpQvdbYFkVi/P6CTV5skp8QlyVQL7l/aFhQOOrQOvgpIGUZoKb+ X-Received: by 2002:a63:eb49:: with SMTP id b9mr13802591pgk.196.1549671169831; Fri, 08 Feb 2019 16:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549671169; cv=none; d=google.com; s=arc-20160816; b=e41xiiK2ZAZlmOdrXIJO98gS8khYpFhpL8QehNaokKkUuBWAiyzQ9u0SiBQus0Cl1H AL8lqa68sfP8ed1sW8SRoQtMwBENQYZcH6AJaysX6/ALy7sJ2Mt8qTUH9k3i+risw41u Qxf+ZzoNKSWGn9e8Xbzz4OReYuDxjtTLpiiA68x/Pf6BurVKZvXV9Z8dwLskod+j4EK6 mCKgv/H5oPOZE90wtXNbk8OxOHLhpo3YJdDS32mdPoriVpZf2NyTiLiW4iUipIfW7wF+ BvC5sv2Tag4E8sDvSEvpqKjVZa5w9yRbYY/IENg+JIH0RvlHdqzNpjpSecHNVQ46vQBZ emJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yhYIaC5gz39kMk0XdTT3RBhkaXLXWFgcj39sN67FslM=; b=u1DREmOFZ7pQv3A2nhWugmRi3sFd15siLhnD/e82XOGKq6y/FaeHg2pi+hVsQL5IrI EbiuqdIA4IDBkYTG/G+vbIvKuxialgQHJHWXdrzlrrrIY4swhhsr7Thjxi4Fx/TWKuBh H0bC+1RgmfEANoW6nHrilsUzJCDE2VocAL828HsvMSMiw1D3QOtMiUffAFRv+03ZM5CC sN9dIRHelbTH+1e+Iksv+yXwO/yirS7+B0IeDACCV7tUMnXFA/T7vk6NJ5bqWJiY7oEP 4KC8Du7kelqr0brCLG+BBAN0eMuLKbsRqCMrboSdkbWgLAgdfOu64I3g7brgvdXCyW++ B+Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ry+YCTt7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k22si3629951pll.276.2019.02.08.16.12.34; Fri, 08 Feb 2019 16:12:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ry+YCTt7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726699AbfBIAJG (ORCPT + 99 others); Fri, 8 Feb 2019 19:09:06 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52546 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfBIAJG (ORCPT ); Fri, 8 Feb 2019 19:09:06 -0500 Received: by mail-wm1-f65.google.com with SMTP id m1so6280048wml.2 for ; Fri, 08 Feb 2019 16:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yhYIaC5gz39kMk0XdTT3RBhkaXLXWFgcj39sN67FslM=; b=Ry+YCTt7y/ppYSoDUEvZsYoqnYumg4MlJz70eigFujPaYOPk6qJLa0QViwmFj463NZ s9JpPnR0Vc5udq1uvkXl8rNuk5UrfV6uGdm7Bey6L+DbEgzGta8/SzBRfnWIVOJoEKXl hMPBvnK8fYx0QFRqW6c+4TwOYpbBzqnZwvqErQVqZyRFC4eiDMXvET5SL4kZ4ASwFN4h F1NMe+xx3IGpOkMOzCQDLjcfSoZhWOmLavDzvaWMBb3nyg+Q5NO4u2u12GrJi/Vd7+B+ tB5T2qvgB6yeymkYPYdQHANwwngfSJDVyD0OdPQ0so33Jy1CdkIdJmZgRIPf7TnGnFHP tR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yhYIaC5gz39kMk0XdTT3RBhkaXLXWFgcj39sN67FslM=; b=F7GGpXXh407J00CfKq1nH8csQ+Cqaly+vxsvR0QvkQ6GoJ0Vt0wjnO9YmRTSBMWjq/ NoeKK2ZFTzQeOUSr4DkAUkN9NrRqu8x25v7G8e8VO20Sd5UlXa6SxUl2l/vCYbKEjMBn YM1ozCYLAYpCRIrcmUEt1a9K7OQQ7+w0HrrBcnzWZ/yETnhad86/9R7dN4pJoMrWlf8E OrteEEI2JNloH/Rw35w1o4jIijUOXgneSRDwXkWolfYmDVPeTrmvpmJ5ZSghRPLiilhR UQEC/HSWEJlWHOh9KvTWI1yKuwRvKUQ6WIjHmBlP8baWt6yp8YIcScPxAUuhPT+q0DmE +xMw== X-Gm-Message-State: AHQUAuZ5eLU8Xg1auzKlFBVjd127LrFVDOv2+82FEYiyiMlUOAnSFeTA 0aL8kpbWz14d3WSK7Ymu4lZp+SYL7dgDtw== X-Received: by 2002:adf:dcd0:: with SMTP id x16mr18385976wrm.143.1549670943582; Fri, 08 Feb 2019 16:09:03 -0800 (PST) Received: from localhost.localdomain (79.108.96.12.dyn.user.ono.com. [79.108.96.12]) by smtp.gmail.com with ESMTPSA id 65sm10483171wrb.62.2019.02.08.16.09.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 16:09:02 -0800 (PST) From: Miguel Ojeda To: linux-kernel@vger.kernel.org Cc: Miguel Ojeda , Laura Abbott , Arnd Bergmann , Martin Sebor , Herbert Xu , Ard Biesheuvel , Krzysztof Kozlowski , Catalin Marinas , Nick Desaulniers , Luc Van Oostenryck , Andrey Konovalov , Kees Cook , Sean Christopherson , Jessica Yu , Masahiro Yamada , James Morris , Mathieu Desnoyers , Borislav Petkov , Matt Mullins , Vincent Whitchurch , WANG Chao Subject: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings Date: Sat, 9 Feb 2019 01:08:37 +0100 Message-Id: <20190209000840.11018-1-miguel.ojeda.sandonis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The upcoming GCC 9 release extends the -Wmissing-attributes warnings (enabled by -Wall) to C and aliases: it warns when particular function attributes are missing in the aliases but not in their target, e.g.: void __cold f(void) {} void __alias("f") g(void); diagnoses: warning: 'g' specifies less restrictive attribute than its target 'f': 'cold' [-Wmissing-attributes] These patch series clean these new warnings. Most of them are caused by the module_init/exit macros. The first patch has been in -next for a long time already, and an alternative solution (only __cold) for module.h as well. However, since we decided to go with the new __copy attribute, I will leave the series for a few days again and send the PR for -rc7. Link: https://lore.kernel.org/lkml/20190125104353.2791-1-labbott@redhat.com/ Miguel Ojeda (3): lib/crc32.c: mark crc32_le_base/__crc32c_le_base aliases as __pure Compiler Attributes: add support for __copy (gcc >= 9) include/linux/module.h: copy __init/__exit attrs to init/cleanup_module include/linux/compiler_attributes.h | 14 ++++++++++++++ include/linux/module.h | 4 ++-- lib/crc32.c | 4 ++-- 3 files changed, 18 insertions(+), 4 deletions(-) -- 2.17.1